Summary: | If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Circulation | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | alexbuckley, caroline.cyr-la-rose, fridolin.somers, gmcharlt, kyle.m.hall, lucas, martin.renvoize, phil |
Version: | Main | Keywords: | rel_24_05_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.08
|
Circulation function: | |
Bug Depends on: | 27753 | ||
Bug Blocks: | |||
Attachments: |
Bug 38246: Only check unresolved claims
Bug 38246: Perltidy Bug 38246: Only check unresolved claims Bug 38246: Perltidy Bug 38246: Only check unresolved claims Bug 38246: Perltidy Bug 38246: [24.05.x] Only check unresolved claims |
Description
Emily Lamancusa (emlam)
2024-10-23 19:31:31 UTC
Created attachment 173238 [details] [review] Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Created attachment 173239 [details] [review] Bug 38246: Perltidy QA tool failed because the previous patch added one line to a large block of code that was incorrectly indented. Fixed the indentation separately on this patch. Created attachment 173248 [details] [review] Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 173249 [details] [review] Bug 38246: Perltidy QA tool failed because the previous patch added one line to a large block of code that was incorrectly indented. Fixed the indentation separately on this patch. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 173497 [details] [review] Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 173498 [details] [review] Bug 38246: Perltidy QA tool failed because the previous patch added one line to a large block of code that was incorrectly indented. Fixed the indentation separately on this patch. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Doesn't clean apply to 24.05.x, rebase if needed. (In reply to Lucas Gass (lukeg) from comment #8) > Doesn't clean apply to 24.05.x, rebase if needed. I do reproduce the bug on 24.05, so yes, it should be backported. The first patch applies cleanly for me, and the second patch is just a big whitespace perltidy of existing code. I'll rebase the perltidy if it's necessary, but it would also be fine to just pick the first patch for backport if you're okay with that. Created attachment 175578 [details] [review] Bug 38246: [24.05.x] Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Reopened to add rebased patch for 24.05.x backport Hi Emily, I have applied your third patch to 24.05.x and the test plan worked as expected. Could you please clarify for us, should we only be applying and backporting the third patch? Thanks, Alex (In reply to Alex Buckley from comment #12) > Hi Emily, > > I have applied your third patch to 24.05.x and the test plan worked as > expected. > > Could you please clarify for us, should we only be applying and backporting > the third patch? > > Thanks, > Alex Yes, just backport the third patch - it's a rebased equivalent of the first two, since they didn't apply cleanly to 24.05.x. (I can't remember now why I decided to combine them into one patch when doing the rebase ^^") Thank you for backporting! (In reply to Emily Lamancusa (emlam) from comment #13) > (In reply to Alex Buckley from comment #12) > > Hi Emily, > > > > I have applied your third patch to 24.05.x and the test plan worked as > > expected. > > > > Could you please clarify for us, should we only be applying and backporting > > the third patch? > > > > Thanks, > > Alex > > Yes, just backport the third patch - it's a rebased equivalent of the first > two, since they didn't apply cleanly to 24.05.x. (I can't remember now why I > decided to combine them into one patch when doing the rebase ^^") Thank you > for backporting! Hi Emily, Thank you for that! We probably won't be able to include it in the 24.05.07 release, due to time constraints - but it's on the list for backporting in the 24.05.08 release! Nice work everyone! Pushed to 24.05.x for 24.05.08 Depends on Bug 27753 not in 23.11.x Big fix, nothing to add/edit in the manual. |