Summary: | Add permission check for erm permission to additional-fields.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Derscheid <paul.derscheid> |
Component: | ERM | Assignee: | Paul Derscheid <paul.derscheid> |
Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jonathan.field, lucas, martin.renvoize, matt.blenkinsop, pedro.amorim, wainuiwitikapark |
Version: | Main | Keywords: | Academy, Sandbox |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Bug Depends on: | 35287 | ||
Bug Blocks: | |||
Attachments: |
Bug 38272: Add permission check for erm permission to additional-fields.tt
Bug 38272: Additionally fix typo in condition for acquisition orders permission |
Description
Paul Derscheid
2024-10-25 12:23:29 UTC
Created attachment 173353 [details] [review] Bug 38272: Add permission check for erm permission to additional-fields.tt Created attachment 173354 [details] [review] Bug 38272: Additionally fix typo in condition for acquisition orders permission To test: 1) Create a user with just erm and catalogue permissions. 2) Open additional-fields.pl 3) Notice that nothing is displayed 4) Change the permission of the user to just manage aquisition orders and catalogue 5) Navigate back to additional-fields.pl 6) Notice that nothing is displayed 7) Apply patch 8) Repeat 1-6 but notice this time that the respective entries are displayed 9) Sign off Treating this as a follow-up. Please include test plans in your commit messages tho ;) Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 (In reply to Lucas Gass (lukeg) from comment #6) > Backported to 24.05.x for upcoming 24.05.06 But Bug 35287 is not in 24.05.x (In reply to Fridolin Somers from comment #7) > (In reply to Lucas Gass (lukeg) from comment #6) > > Backported to 24.05.x for upcoming 24.05.06 > > But Bug 35287 is not in 24.05.x Can the version perhaps be changed to 24.11 if that's the only place where the bug exists? I will revert from 24.05 now (In reply to Wainui Witika-Park from comment #8) > (In reply to Fridolin Somers from comment #7) > > (In reply to Lucas Gass (lukeg) from comment #6) > > > Backported to 24.05.x for upcoming 24.05.06 > > > > But Bug 35287 is not in 24.05.x > > Can the version perhaps be changed to 24.11 if that's the only place where > the bug exists? > > I will revert from 24.05 now I have reverted these patches from 24.05 Pushed to 24.05.06 |