Bug 38272 - Add permission check for erm permission to additional-fields.tt
Summary: Add permission check for erm permission to additional-fields.tt
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Paul Derscheid
QA Contact: Testopia
URL:
Keywords: Academy, Sandbox
Depends on: 35287
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-25 12:23 UTC by Paul Derscheid
Modified: 2024-12-16 02:04 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38272: Add permission check for erm permission to additional-fields.tt (1.13 KB, patch)
2024-10-25 12:29 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 38272: Additionally fix typo in condition for acquisition orders permission (1.15 KB, patch)
2024-10-25 12:29 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Derscheid 2024-10-25 12:23:29 UTC
There was an oversight when adding additional fields support for erm licenses.
In the permission check, we don't check yet for CAN_user_erm.
Comment 1 Paul Derscheid 2024-10-25 12:29:18 UTC
Created attachment 173353 [details] [review]
Bug 38272: Add permission check for erm permission to additional-fields.tt
Comment 2 Paul Derscheid 2024-10-25 12:29:20 UTC
Created attachment 173354 [details] [review]
Bug 38272: Additionally fix typo in condition for acquisition orders permission
Comment 3 Paul Derscheid 2024-10-25 12:38:56 UTC
To test:
1) Create a user with just erm and catalogue permissions.
2) Open additional-fields.pl
3) Notice that nothing is displayed
4) Change the permission of the user to just manage aquisition orders and catalogue
5) Navigate back to additional-fields.pl
6) Notice that nothing is displayed
7) Apply patch
8) Repeat 1-6 but notice this time that the respective entries are displayed
9) Sign off
Comment 4 Katrin Fischer 2024-10-25 12:43:12 UTC
Treating this as a follow-up. Please include test plans in your commit messages tho ;)
Comment 5 Katrin Fischer 2024-10-25 13:39:10 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-20 23:31:55 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-13 15:10:02 UTC
(In reply to Lucas Gass (lukeg) from comment #6)
> Backported to 24.05.x for upcoming 24.05.06

But Bug 35287 is not in 24.05.x
Comment 8 Wainui Witika-Park 2024-12-16 01:45:38 UTC
(In reply to Fridolin Somers from comment #7)
> (In reply to Lucas Gass (lukeg) from comment #6)
> > Backported to 24.05.x for upcoming 24.05.06
> 
> But Bug 35287 is not in 24.05.x

Can the version perhaps be changed to 24.11 if that's the only place where the bug exists?

I will revert from 24.05 now
Comment 9 Wainui Witika-Park 2024-12-16 02:04:13 UTC
(In reply to Wainui Witika-Park from comment #8)
> (In reply to Fridolin Somers from comment #7)
> > (In reply to Lucas Gass (lukeg) from comment #6)
> > > Backported to 24.05.x for upcoming 24.05.06
> > 
> > But Bug 35287 is not in 24.05.x
> 
> Can the version perhaps be changed to 24.11 if that's the only place where
> the bug exists?
> 
> I will revert from 24.05 now

I have reverted these patches from 24.05