Bug 38276

Created attachment 173399 [details] [review]
Bug 38276: Add DOI to openURL

Test plan:
1) Enable ILLModule
2) Login on OPAC (if you haven't already)
3) Access the following openURL link:
localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&doi=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58
4) Notice the DOI is considered a custom field, and the actual DOI native field is not populated.
5) Apply patch. Repeat 4. Notice the native field is populated and is no longer a custom field entry.

Original patch:
https://github.com/PTFS-Europe/koha-ill-freeform/commit/6f00282af427aae632c274e647ef0d61a78fd819

Created attachment 173418 [details] [review]
Bug 38276: Add DOI to openURL

Test plan:
1) Enable ILLModule
2) Login on OPAC (if you haven't already)
3) Access the following openURL link:
localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&doi=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58
4) Notice the DOI is considered a custom field, and the actual DOI native field is not populated.
5) Apply patch. Repeat 4. Notice the native field is populated and is no longer a custom field entry.

Original patch:
https://github.com/PTFS-Europe/koha-ill-freeform/commit/6f00282af427aae632c274e647ef0d61a78fd819

Signed-off-by: David Nind <david@davidnind.com>

Testing notes (using KTD):

1. Apply bug 35570 (plus run an updatedatabase and restart_all) before starting the test plan.

2. When applying the patch for this bug (38276), say 'n' to not follow the dependant bug.

Comment:

1. In the OPAC (Interlibrary loan requests section) the patron can view the request (View button). 

2. When viewing the request, there are options at the bottom of the form for "Request cancellation" and "Submit modifications".

3. However, the only field you can change or add any anything to is the "Notes" field. 

4. Is this by design, or should the button be relabelled? For example, rename to "Add a note to your request".

(In reply to David Nind from comment #3)
> 4. Is this by design, or should the button be relabelled? For example,
> rename to "Add a note to your request".

Hi David, thank you for testing + sign-off.
I believe this is by design, as allowing the patron to edit the request's metadata after it has been placed could cause all sorts of workflow issues.

Created attachment 173558 [details] [review]
Bug 38276: Add DOI to openURL

Test plan:
1) Enable ILLModule
2) Login on OPAC (if you haven't already)
3) Access the following openURL link:
localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&doi=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58
4) Notice the DOI is considered a custom field, and the actual DOI native field is not populated.
5) Apply patch. Repeat 4. Notice the native field is populated and is no longer a custom field entry.

Original patch:
https://github.com/PTFS-Europe/koha-ill-freeform/commit/6f00282af427aae632c274e647ef0d61a78fd819

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Categorizing as an enhancement as it depends on one that is not in yet.

Pushed for 24.11!

Well done everyone, thank you!