Bug 38376 - ILL Standard form does not consider id in openURL
Summary: ILL Standard form does not consider id in openURL
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-06 11:29 UTC by Pedro Amorim
Modified: 2024-12-05 22:18 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This update will recognize the 'id' parameter in an openURL as a 'DOI', ensuring compatibility with version 0.1 of the OpenURL format standard. For more information, visit: https://www.doi.org/the-identifier/resources/factsheets/doi-system-and-openurl.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38376: Add id to openURL as DOI (1.42 KB, patch)
2024-11-06 11:33 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38376: Add id to openURL as DOI (1.47 KB, patch)
2024-11-06 22:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 38376: Add id to openURL as DOI (1.53 KB, patch)
2024-11-08 16:33 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-11-06 11:29:19 UTC
Similar to bug 38276, but for 'id'.

From https://www.doi.org/the-identifier/resources/factsheets/doi-system-and-openurl. Quote:
"The OpenURL Format standard approved by the NISO voting members includes significant changes made between Versions 0.1 and 1.0. Relevant to DOI names, in OpenURL Format Version 1.0, ‘### rft_id’ replaced ‘### id’ which was used in Version 0.1."

Some systems using openURL into Koha are still using the old version 'id' for DOI.
Comment 1 Pedro Amorim 2024-11-06 11:33:35 UTC
Created attachment 174073 [details] [review]
Bug 38376: Add id to openURL as DOI

Test plan:
1) Enable ILLModule
2) Login on OPAC (if you haven't already)
3) Access the following openURL link:
localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&id=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58
4) Notice the 'id' is considered a custom field, and is not converted into the DOI native field.
5) Apply patch. Restart plack. Repeat 4. Notice the native field is populated and a custom field entry no longer exists.
Comment 2 David Nind 2024-11-06 22:23:59 UTC
Created attachment 174099 [details] [review]
Bug 38376: Add id to openURL as DOI

Test plan:
1) Enable ILLModule
2) Login on OPAC (if you haven't already)
3) Access the following openURL link:
localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&id=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58
4) Notice the 'id' is considered a custom field, and is not converted into the DOI native field.
5) Apply patch. Restart plack. Repeat 4. Notice the native field is populated and a custom field entry no longer exists.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2024-11-08 16:33:31 UTC
Created attachment 174286 [details] [review]
Bug 38376: Add id to openURL as DOI

Test plan:
1) Enable ILLModule
2) Login on OPAC (if you haven't already)
3) Access the following openURL link:
localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&id=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58
4) Notice the 'id' is considered a custom field, and is not converted into the DOI native field.
5) Apply patch. Restart plack. Repeat 4. Notice the native field is populated and a custom field entry no longer exists.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-11-11 15:14:08 UTC
Should we consider this a bug instead of enh?
Comment 5 Pedro Amorim 2024-11-11 15:16:09 UTC
(In reply to Katrin Fischer from comment #4)
> Should we consider this a bug instead of enh?

Categorized as enhancement as it's adding support to an older way of passing the DOI through openURL, but I don't feel strongly either way.
Comment 6 Katrin Fischer 2024-11-11 16:44:02 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-12-05 22:18:55 UTC
Not needed in 24.05.x