| Summary: | Patron search modal has a button opened by a <button> and closed by a </a> | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Victor Grousset/tuxayo <victor> |
| Component: | Patrons | Assignee: | Ewa Gózd <ewa.gozd> |
| Status: | Pushed to main --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | ewa.gozd, gmcharlt, kyle.m.hall, lucas |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 38283: fixed wrong ending tag in patron search modal
Bug 38283: fixed wrong ending tag in patron search modal Bug 38283: fixed wrong ending tag in patron search modal Bug 38283: fixed wrong ending tag in patron search modal Bug 38283: fixed wrong ending tag in patron search modal |
||
|
Description
Victor Grousset/tuxayo
2024-10-28 21:29:23 UTC
This would be good for our hackfest next week. Should it be a or button? :) (In reply to Katrin Fischer from comment #1) > This would be good for our hackfest next week. Luckily I remembered! > Should it be a or button? :) It really doesn't matter from the perspective of style or functionality but <button> is more consistent. Created attachment 173966 [details] [review] Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Created attachment 173967 [details] [review] Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Created attachment 173968 [details] [review] Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Created attachment 173970 [details] [review] Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Signed-off-by: Jan Steinberg <jan.steinberg@gesis.org> Created attachment 174043 [details] [review] Bug 38283: fixed wrong ending tag in patron search modal Fixed mis-matched a/button tags on "Close" button. To test: - Apply patch - In staff interface: Go to acquisitions > suggestions - Create a new suggestion - Click on "Set to patron" - Verify the close button in the modal looks correct and works Signed-off-by: Jan Steinberg <jan.steinberg@gesis.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! |