Bug 38283 - Patron search modal has a button opened by a <button> and closed by a </a>
Summary: Patron search modal has a button opened by a <button> and closed by a </a>
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Ewa Gózd
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2024-10-28 21:29 UTC by Victor Grousset/tuxayo
Modified: 2024-11-07 17:51 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 38283: fixed wrong ending tag in patron search modal (1.26 KB, patch)
2024-11-05 10:46 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 38283: fixed wrong ending tag in patron search modal (1.27 KB, patch)
2024-11-05 10:54 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 38283: fixed wrong ending tag in patron search modal (1.26 KB, patch)
2024-11-05 10:55 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 38283: fixed wrong ending tag in patron search modal (1.32 KB, patch)
2024-11-05 11:19 UTC, Jan Steinberg 		Details | Diff | Splinter Review
Bug 38283: fixed wrong ending tag in patron search modal (1.37 KB, patch)
2024-11-05 20:32 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2024-10-28 21:29:23 UTC 
<button type="button" class="btn btn-default cancel" data-bs-dismiss="modal">Close</a>

https://git.koha-community.org/Koha-community/Koha/src/commit/247ab7d1acf087dc689aead0bd509f0c594b8d12/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc#L1015
Comment 1 Katrin Fischer 2024-10-29 07:51:24 UTC 
This would be good for our hackfest next week. Should it be a or button? :)
Comment 2 Owen Leonard 2024-10-29 09:25:19 UTC 
(In reply to Katrin Fischer from comment #1)
> This would be good for our hackfest next week.

Luckily I remembered!

>  Should it be a or button? :)

It really doesn't matter from the perspective of style or functionality but <button> is more consistent.
Comment 3 Katrin Fischer 2024-11-05 10:46:20 UTC 
Created attachment 173966 [details] [review]
Bug 38283: fixed wrong ending tag in patron search modal

Fixed mis-matched a/button tags on "Close" button.

To test:
- Apply patch
- In staff interface: Go to acquisitions > suggestions
- Create a new suggestion
- Click on "Set to patron"
- Verify the close button in the modal looks correct and works
Comment 4 Katrin Fischer 2024-11-05 10:54:25 UTC 
Created attachment 173967 [details] [review]
Bug 38283: fixed wrong ending tag in patron search modal

Fixed mis-matched a/button tags on "Close" button.

To test:
- Apply patch
- In staff interface: Go to acquisitions > suggestions
- Create a new suggestion
- Click on "Set to patron"
- Verify the close button in the modal looks correct and works
Comment 5 Katrin Fischer 2024-11-05 10:55:43 UTC 
Created attachment 173968 [details] [review]
Bug 38283: fixed wrong ending tag in patron search modal

Fixed mis-matched a/button tags on "Close" button.

To test:
- Apply patch
- In staff interface: Go to acquisitions > suggestions
- Create a new suggestion
- Click on "Set to patron"
- Verify the close button in the modal looks correct and works
Comment 6 Jan Steinberg 2024-11-05 11:19:17 UTC 
Created attachment 173970 [details] [review]
Bug 38283: fixed wrong ending tag in patron search modal

Fixed mis-matched a/button tags on "Close" button.

To test:
- Apply patch
- In staff interface: Go to acquisitions > suggestions
- Create a new suggestion
- Click on "Set to patron"
- Verify the close button in the modal looks correct and works

Signed-off-by: Jan Steinberg <jan.steinberg@gesis.org>
Comment 7 Lucas Gass (lukeg) 2024-11-05 20:32:41 UTC 
Created attachment 174043 [details] [review]
Bug 38283: fixed wrong ending tag in patron search modal

Fixed mis-matched a/button tags on "Close" button.

To test:
- Apply patch
- In staff interface: Go to acquisitions > suggestions
- Create a new suggestion
- Click on "Set to patron"
- Verify the close button in the modal looks correct and works

Signed-off-by: Jan Steinberg <jan.steinberg@gesis.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Katrin Fischer 2024-11-07 17:51:24 UTC 
Pushed for 24.11!

Well done everyone, thank you!