Bug 38286

Summary: Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: normal    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, lucas, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Attachments: Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set

Description Jonathan Druart 2024-10-29 12:51:37 UTC

    
Comment 1 Jonathan Druart 2024-10-29 12:54:40 UTC
Created attachment 173635 [details] [review]
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set

Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set

Test plan:
  prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/api/v1/biblios.t
Should return green

Confirm the assumption above is correct.
Comment 2 Jonathan Druart 2024-10-29 12:54:53 UTC
Note that t/db_dependent/api/v1/biblios.t is currently failing on main.
Comment 3 Tomás Cohen Arazi (tcohen) 2024-10-29 13:16:26 UTC
Created attachment 173645 [details] [review]
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set

Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set

Test plan:
  prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/api/v1/biblios.t
Should return green

Confirm the assumption above is correct.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-29 13:16:47 UTC
Nice catch!
Comment 5 Katrin Fischer 2024-10-30 13:45:55 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-12-05 21:14:15 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-18 09:35:14 UTC
Makes sens but I prefer not backport to 23.11.x in case of side effects
Comment 8 Caroline Cyr La Rose 2025-04-18 19:38:11 UTC
Internal architecture, nothing to add/edit in the manual.