Summary: | Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, lucas, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Attachments: |
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set |
Description
Jonathan Druart
2024-10-29 12:51:37 UTC
Created attachment 173635 [details] [review] Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set Test plan: prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/api/v1/biblios.t Should return green Confirm the assumption above is correct. Note that t/db_dependent/api/v1/biblios.t is currently failing on main. Created attachment 173645 [details] [review] Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set Test plan: prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/api/v1/biblios.t Should return green Confirm the assumption above is correct. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Nice catch! Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Makes sens but I prefer not backport to 23.11.x in case of side effects Internal architecture, nothing to add/edit in the manual. |