38286 – Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set

Bug 38286 - Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set

Summary: Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenIte...

Status:	Pushed to main

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low normal
Assignee:	Jonathan Druart
QA Contact:	Tomás Cohen Arazi (tcohen)

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-10-29 12:51 UTC by Jonathan Druart
Modified:	2024-11-13 15:51 UTC (History)
CC List:	1 user (show)

See Also:	31224
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.11.00
Circulation function:

Attachments
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set (1.31 KB, patch) 2024-10-29 12:54 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set (1.36 KB, patch) 2024-10-29 13:16 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2024-10-29 12:51:37 UTC

Comment 1 Jonathan Druart 2024-10-29 12:54:40 UTC

Created attachment 173635 [details] [review]
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set

Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set

Test plan:
  prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/api/v1/biblios.t
Should return green

Confirm the assumption above is correct.

Comment 2 Jonathan Druart 2024-10-29 12:54:53 UTC

Note that t/db_dependent/api/v1/biblios.t is currently failing on main.

Comment 3 Tomás Cohen Arazi (tcohen) 2024-10-29 13:16:26 UTC

Created attachment 173645 [details] [review]
Bug 38286: Do not fetch the items if OpacHiddenItemsHidesRecord is set

Koha::Biblio:hidden_in_opac does not need to fetch the items if OpacHiddenItemsHidesRecord is set

Test plan:
  prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Item.t t/db_dependent/api/v1/biblios.t
Should return green

Confirm the assumption above is correct.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-29 13:16:47 UTC

Nice catch!

Comment 5 Katrin Fischer 2024-10-30 13:45:55 UTC

Pushed for 24.11!

Well done everyone, thank you!