Summary: | EDIFACT breadcrumbs need to be permissions based | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | Acquisitions | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | Needs documenting --- | QA Contact: | Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | baptiste.wojtkowski, david, fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the breadcrumbs to EDI accounts, so that the 'Administration' breadcrumb link is not shown if the staff patron doesn't have permission to access administration pages, but does have permission to manage EDIT accounts (Acquisitions > Administration > EDI accounts).
What happens after this change:
- Administration permissions: sees Administration > EDI accounts (no change)
- Only Manage EDIFACT transmissions (edi_manage) permissions: sees Acquisitions > EDI accounts (previously Administration > EDI accounts was shown, but they couldn't access the administration pages)
|
|
Version(s) released in: |
25.11.00,25.05.01
|
Circulation function: | |
Attachments: |
Bug 38298: Add permission checks to EDI breadcrumbs
Bug 38298: Add permission checks to EDI breadcrumbs Bug 38298: Add permission checks to EDI breadcrumbs |
Description
Matt Blenkinsop
2024-10-30 12:10:08 UTC
Created attachment 173714 [details] [review] Bug 38298: Add permission checks to EDI breadcrumbs Test plan: 1) Choose a staff patron and assign them the following permissions - catalogue - edi_manage 2) Enable the edifact syspref 3) Log in as the chosen staff patron and navigate to Acquisitions > EDI accounts from the left hand menu 4) The breadcrumb will contain Administration 5) Clicking this will result in a permissions error 6) Apply patch 7) Refresh the page and the breadcrumb will now read Acquisitions and will work Created attachment 180099 [details] [review] Bug 38298: Add permission checks to EDI breadcrumbs Test plan: 1) Choose a staff patron and assign them the following permissions - catalogue - edi_manage 2) Enable the edifact syspref 3) Log in as the chosen staff patron and navigate to Acquisitions > EDI accounts from the left hand menu 4) The breadcrumb will contain Administration 5) Clicking this will result in a permissions error 6) Apply patch 7) Refresh the page and the breadcrumb will now read Acquisitions and will work Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 182857 [details] [review] Bug 38298: Add permission checks to EDI breadcrumbs Test plan: 1) Choose a staff patron and assign them the following permissions - catalogue - edi_manage 2) Enable the edifact syspref 3) Log in as the chosen staff patron and navigate to Acquisitions > EDI accounts from the left hand menu 4) The breadcrumb will contain Administration 5) Clicking this will result in a permissions error 6) Apply patch 7) Refresh the page and the breadcrumb will now read Acquisitions and will work Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Nice work everyone! Pushed to main for 25.11 I see in 25.05.x I prefer not backport to 24.11.x for stability |