Bug 38298 - EDIFACT breadcrumbs need to be permissions based
Summary: EDIFACT breadcrumbs need to be permissions based
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-30 12:10 UTC by Matt Blenkinsop
Modified: 2025-06-30 22:21 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the breadcrumbs to EDI accounts, so that the 'Administration' breadcrumb link is not shown if the staff patron doesn't have permission to access administration pages, but does have permission to manage EDIT accounts (Acquisitions > Administration > EDI accounts). What happens after this change: - Administration permissions: sees Administration > EDI accounts (no change) - Only Manage EDIFACT transmissions (edi_manage) permissions: sees Acquisitions > EDI accounts (previously Administration > EDI accounts was shown, but they couldn't access the administration pages)
Version(s) released in:
25.11.00,25.05.01
Circulation function:


Attachments
Bug 38298: Add permission checks to EDI breadcrumbs (1.61 KB, patch)
2024-10-30 12:14 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38298: Add permission checks to EDI breadcrumbs (1.66 KB, patch)
2025-04-01 09:04 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 38298: Add permission checks to EDI breadcrumbs (1.72 KB, patch)
2025-05-30 13:03 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-10-30 12:10:08 UTC
The breadcrumbs in ed_accounts.pl point to Administration but if the user doesn't have permissions for this then they can't access the page. It should be permissions based and point to acquisitions if they don't have permission to access administrations
Comment 1 Matt Blenkinsop 2024-10-30 12:14:32 UTC
Created attachment 173714 [details] [review]
Bug 38298: Add permission checks to EDI breadcrumbs

Test plan:
1) Choose a staff patron and assign them the following permissions
    - catalogue
    - edi_manage
2) Enable the edifact syspref
3) Log in as the chosen staff patron and navigate to Acquisitions > EDI accounts from the left hand menu
4) The breadcrumb will contain Administration
5) Clicking this will result in a permissions error
6) Apply patch
7) Refresh the page and the breadcrumb will now read Acquisitions and will work
Comment 2 Brendan Gallagher 2025-04-01 09:04:09 UTC
Created attachment 180099 [details] [review]
Bug 38298: Add permission checks to EDI breadcrumbs

Test plan:
1) Choose a staff patron and assign them the following permissions
    - catalogue
    - edi_manage
2) Enable the edifact syspref
3) Log in as the chosen staff patron and navigate to Acquisitions > EDI accounts from the left hand menu
4) The breadcrumb will contain Administration
5) Clicking this will result in a permissions error
6) Apply patch
7) Refresh the page and the breadcrumb will now read Acquisitions and will work

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 3 Baptiste Wojtkowski (bwoj) 2025-05-30 13:03:24 UTC
Created attachment 182857 [details] [review]
Bug 38298: Add permission checks to EDI breadcrumbs

Test plan:
1) Choose a staff patron and assign them the following permissions
    - catalogue
    - edi_manage
2) Enable the edifact syspref
3) Log in as the chosen staff patron and navigate to Acquisitions > EDI accounts from the left hand menu
4) The breadcrumb will contain Administration
5) Clicking this will result in a permissions error
6) Apply patch
7) Refresh the page and the breadcrumb will now read Acquisitions and will work

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 4 Lucas Gass (lukeg) 2025-06-04 22:08:19 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Fridolin Somers 2025-06-19 07:55:39 UTC
I see in 25.05.x
Comment 6 Fridolin Somers 2025-06-19 07:56:21 UTC
I prefer not backport to 24.11.x for stability