Bug 38300

Summary: Cancelling holds in bulk should not need localStorage
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Hold requestsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: clackman, gmcharlt, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 38295    
Bug Blocks:    

Description Jonathan Druart 2024-10-30 14:55:47 UTC
We are storing the selected holds in localStorage, we should not need that.
Once we selected and cancelled them, a fresh table (without nothing checked) should be shown.

There is some code to reset it
251             if(!localStorage.selectedWaitingHolds || document.referrer.replace(/\?.*/, '') !== document.location.origin+document.location.pathname) {
252                 localStorage.selectedWaitingHolds = '[]';
253             }

But it does not work in all situations.

I think we simply need to use a JS variable, or I am missing something.
Comment 1 Jonathan Druart 2024-10-30 14:56:35 UTC
Consider the work on bug 38295 (and the possibility to use Select DT's extension)