Bug 38300 - Cancelling holds in bulk should not need localStorage
Summary: Cancelling holds in bulk should not need localStorage
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 38295
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-30 14:55 UTC by Jonathan Druart
Modified: 2024-10-31 17:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-30 14:55:47 UTC
We are storing the selected holds in localStorage, we should not need that.
Once we selected and cancelled them, a fresh table (without nothing checked) should be shown.

There is some code to reset it
251             if(!localStorage.selectedWaitingHolds || document.referrer.replace(/\?.*/, '') !== document.location.origin+document.location.pathname) {
252                 localStorage.selectedWaitingHolds = '[]';
253             }

But it does not work in all situations.

I think we simply need to use a JS variable, or I am missing something.
Comment 1 Jonathan Druart 2024-10-30 14:56:35 UTC
Consider the work on bug 38295 (and the possibility to use Select DT's extension)