Bug 38312

Summary: Patron form behind fixed header
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to main --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: minor    
Priority: P5 - low CC: gmcharlt, lucas, phil, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 36694    
Bug Blocks:    
Attachments: Bug 38312: Do not hide patron search form behind the fixed header
Bug 38312: Do not hide patron search form behind the fixed header
Bug 38312: Do not hide patron search form behind the fixed header

Description Jonathan Druart 2024-10-31 14:12:43 UTC
An image better than a painful explanation: https://snipboard.io/oF2gBA.jpg
Comment 1 Jonathan Druart 2024-10-31 14:15:13 UTC
Created attachment 173801 [details] [review]
Bug 38312: Do not hide patron search form behind the fixed header

On the patron search form (/members/members-home.pl) if you open the
patron search form *from the header search*, part of the form will be
hidden behind the fixed header (the one with the select/clear, actions)

Before: https://snipboard.io/oF2gBA.jpg
After : https://snipboard.io/QqMiRH.jpg

Using z-index: 1000 as the header as 999
Comment 2 Phil Ringnalda 2024-10-31 14:54:56 UTC
Created attachment 173807 [details] [review]
Bug 38312: Do not hide patron search form behind the fixed header

On the patron search form (/members/members-home.pl) if you open the
patron search form *from the header search*, part of the form will be
hidden behind the fixed header (the one with the select/clear, actions)

Before: https://snipboard.io/oF2gBA.jpg
After : https://snipboard.io/QqMiRH.jpg

Using z-index: 1000 as the header as 999

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Phil Ringnalda 2024-10-31 15:05:37 UTC
Also fixes the same dropdown in Authorities, yay CSS.
Comment 4 Jonathan Druart 2024-10-31 15:21:38 UTC
> Using z-index: 1000 as the header as 999

*has 999*!
Comment 5 Victor Grousset/tuxayo 2024-11-01 17:18:27 UTC
Maybe it's due to Bug 36694. An RMaint considering to backport would need to be sure to check for the bug existence in stable.
Comment 6 Phil Ringnalda 2024-11-01 17:48:54 UTC
Yeah, it's present in a52a580810 (the last of the bug 36694 patches), and not present in a0cfdccebe (the parent of the bug 36694 patches).
Comment 7 Lucas Gass (lukeg) 2024-11-01 17:50:35 UTC
Created attachment 173884 [details] [review]
Bug 38312: Do not hide patron search form behind the fixed header

On the patron search form (/members/members-home.pl) if you open the
patron search form *from the header search*, part of the form will be
hidden behind the fixed header (the one with the select/clear, actions)

Before: https://snipboard.io/oF2gBA.jpg
After : https://snipboard.io/QqMiRH.jpg

Using z-index: 1000 as the header as 999

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Katrin Fischer 2024-11-07 17:51:31 UTC
Pushed for 24.11!

Well done everyone, thank you!