Summary: | RESTOAuth2ClientCredentials system preference description is confusing | ||
---|---|---|---|
Product: | Koha | Reporter: | Jake Deery <jake.deery> |
Component: | Staff interface | Assignee: | Jake Deery <jake.deery> |
Status: | Pushed to main --- | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials
Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials |
Description
Jake Deery
2024-10-31 14:23:38 UTC
Created attachment 173803 [details] [review] Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Notice how the message is now gone Created attachment 173804 [details] [review] Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone Created attachment 176476 [details] [review] Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone Signed-off-by: William Lavoie <william.lavoie@inLibro.com> cpanfile:recommends 'Net::OAuth2::AuthorizationServer', '0.16'; It's recommends, not requires. I guess that's why it's in the description of the syspref. When you install a package, it is included as a dependency. This can be verified by looking at the metadata of the koha-perldeps package. Perhaps we should update the cpanfile too? Jake. Created attachment 176867 [details] [review] Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone Signed-off-by: William Lavoie <william.lavoie@inLibro.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed for 25.05! Well done everyone, thank you! |