In Bug 20734, we added a string informing sysadmins that Net::OAuth2::AuthorizationServer is required for the RESTOAuth2ClientCredentials syspref to be operable. I don't think we need this anymore, as for git installs this is in the cpanfile, and for package installs this is included as a dependency for koha-perldeps. Could we remove this string to a) tidy things up, and b) avoid confusion of people installing the cpan module twice (once in Debian, and once in cpan-land)? Jake.
Created attachment 173803 [details] [review] Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Notice how the message is now gone
Created attachment 173804 [details] [review] Bug 38313: Remove confusing string from RESTOAuth2ClientCredentials This patch removes a once necessary and now confusing warning from the RESTOAuth2ClientCredentials syspref. TO TEST: a) Notice how the RESTOAuth2ClientCredentials syspref references installing Net::OAuth2::AuthorizationServer, even though this module is in the cpanfile and koha-perldeps and has been since 22.11 b) APPLY PATCH c) Run reset_all in k.t.d d) Notice how the message is now gone