Summary: | dt-select-filter makes some columns too wide on the detail page holdings table | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Cataloging | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | RESOLVED WONTFIX | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, martin.renvoize, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 38319: Control width of dt-select-filter
Bug 38319: Control width of dt-select-filter Screenshot showing obscured selections |
Description
Lucas Gass (lukeg)
2024-10-31 19:34:42 UTC
Created attachment 173952 [details] [review] Bug 38319: Control width of dt-select-filter To test: 1. Find a record with some items. 2. Notice the width of the entire table. 3. Click 'Show filters' 4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters. 5. APPLY PATCH, yarn build 6. Try again, the column width should stay the same. Created attachment 174316 [details] [review] Bug 38319: Control width of dt-select-filter To test: 1. Find a record with some items. 2. Notice the width of the entire table. 3. Click 'Show filters' 4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters. 5. APPLY PATCH, yarn build 6. Try again, the column width should stay the same. Signed-off-by: David Nind <david@davidnind.com> Created attachment 174469 [details]
Screenshot showing obscured selections
A couple of things:
1. I would like this change to be moved to _tables.scss. That's where other DataTables style overrides are.
2. I'm happy for this fix because it has bugged me for a while, but I'm concerned about whether folks will object to the fact that they can't always read the whole string shown in the dropdown after a value has been selected.
If it were up to me I'd say that the benefits outweigh the downsides here, but I'm curious if others have had user feedback about this kind of thing.
Setting to Failed QA for the _tables.scss choice. > 2. I'm happy for this fix because it has bugged me for a while, but I'm
> concerned about whether folks will object to the fact that they can't always
> read the whole string shown in the dropdown after a value has been selected.
Good point here and this is something that is easy enough to adjust with IntranetUserCSS, so maybe we should leave as is and mark this WONTFIX?
(In reply to Jonathan Druart from comment #6) > Note that there are bug 36640 and bug 38310 in the queue ;) Let's set this one to resolved - WONTFIX |