Bug 38319 - dt-select-filter makes some columns too wide on the detail page holdings table
Summary: dt-select-filter makes some columns too wide on the detail page holdings table
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-31 19:34 UTC by Lucas Gass (lukeg)
Modified: 2024-11-13 18:37 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38319: Control width of dt-select-filter (1.09 KB, patch)
2024-11-04 21:42 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38319: Control width of dt-select-filter (1.14 KB, patch)
2024-11-10 19:12 UTC, David Nind
Details | Diff | Splinter Review
Screenshot showing obscured selections (22.60 KB, image/png)
2024-11-13 12:40 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-10-31 19:34:42 UTC
To recreate:

1. Find a record with some items.
2. Notice the width of the entire table.
3. Click 'Show filters'
4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters.


This can make for some wide tables, we can maybe just limit the width via CSS?
Comment 1 Lucas Gass (lukeg) 2024-11-04 21:42:56 UTC
Created attachment 173952 [details] [review]
Bug 38319: Control width of dt-select-filter

To test:
1. Find a record with some items.
2. Notice the width of the entire table.
3. Click 'Show filters'
4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters.
5. APPLY PATCH, yarn build
6. Try again, the column width should stay the same.
Comment 2 David Nind 2024-11-10 19:12:13 UTC
Created attachment 174316 [details] [review]
Bug 38319: Control width of dt-select-filter

To test:
1. Find a record with some items.
2. Notice the width of the entire table.
3. Click 'Show filters'
4. The columns with a dt-select-filter ( Item type, Current library, Home library) are now much wider than without the filters.
5. APPLY PATCH, yarn build
6. Try again, the column width should stay the same.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Owen Leonard 2024-11-13 12:40:42 UTC
Created attachment 174469 [details]
Screenshot showing obscured selections

A couple of things:

1. I would like this change to be moved to _tables.scss. That's where other DataTables style overrides are.

2. I'm happy for this fix because it has bugged me for a while, but I'm concerned about whether folks will object to the fact that they can't always read the whole string shown in the dropdown after a value has been selected.

If it were up to me I'd say that the benefits outweigh the downsides here, but I'm curious if others have had user feedback about this kind of thing.
Comment 4 Owen Leonard 2024-11-13 12:41:35 UTC
Setting to Failed QA for the _tables.scss choice.
Comment 5 Lucas Gass (lukeg) 2024-11-13 14:38:39 UTC
> 2. I'm happy for this fix because it has bugged me for a while, but I'm
> concerned about whether folks will object to the fact that they can't always
> read the whole string shown in the dropdown after a value has been selected.

Good point here and this is something that is easy enough to adjust with IntranetUserCSS, so maybe we should leave as is and mark this WONTFIX?
Comment 6 Jonathan Druart 2024-11-13 14:53:10 UTC
Note that there are bug 36640 and bug 38310 in the queue ;)
Comment 7 Lucas Gass (lukeg) 2024-11-13 18:37:00 UTC
(In reply to Jonathan Druart from comment #6)
> Note that there are bug 36640 and bug 38310 in the queue ;)

Let's set this one to resolved - WONTFIX