Summary: | Fix style of sidebar form clear buttons | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to stable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, Laura.escamilla, m.de.rooy, martin.renvoize, testopia, wainuiwitikapark |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the markup and CSS for sidebar forms that contain a submit button and a clear button (for example, the patrons and ILL requests sidebars). The submit button is now wider than the clear button for visual emphasis.
|
|
Version(s) released in: |
25.05.00, 24.11.02
|
Circulation function: | |
Attachments: |
Bug 38350: Fix style of sidebar form clear buttons
Bug 38350: Fix style of sidebar form clear buttons Bug 38350: Fix style of sidebar form clear buttons Bug 38350: Fix style of sidebar form clear buttons |
Description
Owen Leonard
2024-11-04 16:22:14 UTC
Created attachment 173938 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Ran into some merge issues Bug 38350 - Fix style of sidebar form clear buttons 173938 - Bug 38350: Fix style of sidebar form clear buttons Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38350: Fix style of sidebar form clear buttons Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt M koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt M koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Created attachment 175092 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Created attachment 175236 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 175445 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested This was pushed for 24.11.02 |