In cases where sidebar forms have a submit button alongside a clear button, the submit button is supposed to be larger than the clear button.
Created attachment 173938 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries
Ran into some merge issues Bug 38350 - Fix style of sidebar form clear buttons 173938 - Bug 38350: Fix style of sidebar form clear buttons Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38350: Fix style of sidebar form clear buttons Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss M koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt M koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt M koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc Auto-merging koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
Created attachment 175092 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries
Created attachment 175236 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 175445 [details] [review] Bug 38350: Fix style of sidebar form clear buttons This patch fixes markup and CSS for sidebar form which contain a submit button and a clear button. The submit button is supposed to be wider than the clear button for visual emphasis. To test, apply the patch and rebuild the staff interface CSS. - Go to Patrons and confirm that the sidebar filter form looks correct. If necessary, resize your browser window to confirm that the "Search" button expands as the page gets wider. Confirm that the clear button works as expected. - Perform the same tests on these pages: - Acquisitions -> Vendor -> Receive shipments - ILL requests - Guided reports -> Saved reports Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!