Bug 38367

Summary:	offset is wrong on plugins-disabled.tt page
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Staff interface	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Needs Signoff ---	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	david, gmcharlt
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 38367: Fix offset on plugin-dsiabled.tt Bug 38367: Fix offset on plugin-dsiabled.tt

Description Lucas Gass (lukeg) 2024-11-06 00:10:30 UTC

To recreate:
1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins>
2. Go to Administration -> Plugins
3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5  )
`

Comment 1 Lucas Gass (lukeg) 2024-11-06 00:12:09 UTC

Created attachment 174055 [details] [review]
Bug 38367: Fix offset on plugin-dsiabled.tt

To test:
1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins>
2. Go to Administration -> Plugins
3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5  )
4. APPLY PATCH
5. Try again, the offset should look right.

Comment 2 Owen Leonard 2024-11-06 15:56:52 UTC

The updated markup has "col-sm-6 offset-sm-3 col-md-6 col-md-offset-3", which still includes the old "col-md-offset-3" class.

The previous markup was redundant, because it's the same width and the same offset for both the sm and md breakpoint. We could make it simply "col-sm-6 offset-sm-3" or include a different breakpoint for md, e.g. "col-sm-6 offset-sm-3 col-md-10 offset-md-1"

Comment 3 Lucas Gass (lukeg) 2024-11-06 17:00:37 UTC

Created attachment 174085 [details] [review]
Bug 38367: Fix offset on plugin-dsiabled.tt

To test:
1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins>
2. Go to Administration -> Plugins
3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5  )
4. APPLY PATCH
5. Try again, the offset should look right.

Comment 4 David Nind 2024-11-08 20:03:12 UTC

I had a go at testing, but I can't get this to work.

If you set <enable_plugins>0</enable_plugins>, then there is no Administration > Plugins.

Could you please update the test plan to reflect how to replicate/demonstrate the issue?

Comment 5 Owen Leonard 2024-11-12 13:27:29 UTC

You have to navigate directly to http://127.0.0.1:8081/cgi-bin/koha/plugins/plugins-home.pl