To recreate: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) `
Created attachment 174055 [details] [review] Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right.
The updated markup has "col-sm-6 offset-sm-3 col-md-6 col-md-offset-3", which still includes the old "col-md-offset-3" class. The previous markup was redundant, because it's the same width and the same offset for both the sm and md breakpoint. We could make it simply "col-sm-6 offset-sm-3" or include a different breakpoint for md, e.g. "col-sm-6 offset-sm-3 col-md-10 offset-md-1"
Created attachment 174085 [details] [review] Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right.
I had a go at testing, but I can't get this to work. If you set <enable_plugins>0</enable_plugins>, then there is no Administration > Plugins. Could you please update the test plan to reflect how to replicate/demonstrate the issue?
You have to navigate directly to http://127.0.0.1:8081/cgi-bin/koha/plugins/plugins-home.pl
Created attachment 175033 [details] [review] Bug 38367: Fix offset on plugin-dsiabled.tt To test: 1. Go to your koha-conf.xml and turn plugins off: <enable_plugins>0</enable_plugins> 2. Go to Administration -> Plugins 3. The text is not correctly offset. ( Bootstrap class is col-sm-offset-3 and should be offset-sm-3 in Bootstrap 5 ) 4. APPLY PATCH 5. Try again, the offset should look right. Signed-off-by: David Nind <david@davidnind.com>
(In reply to Owen Leonard from comment #5) > You have to navigate directly to > http://127.0.0.1:8081/cgi-bin/koha/plugins/plugins-home.pl Thanks Owen!