Bug 38373

Summary: Mandatory patron relationship has to be selected twice
Product: Koha Reporter: Johanna Räisä <johanna.raisa>
Component: PatronsAssignee: Johanna Räisä <johanna.raisa>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, jesse, jonathan.druart, kyle.m.hall, lin-wei.li, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: Sponsored
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 38373: check if mandatory relationship is needed for non-patron guarantor
Bug 38373: check if mandatory relationship is needed for non-patron guarantor
Bug 38373: check if mandatory relationship is needed for non-patron guarantor

Description Johanna Räisä 2024-11-06 09:14:40 UTC
When relationship is a mandatory the field has to be selected twice, for non-patron guarantor and patron guarantor.

There should be a some kind of check which input fields are filled and the relationship requirement is based on that.
Comment 1 Johanna Räisä 2024-11-07 07:14:54 UTC
Created attachment 174102 [details] [review]
Bug 38373: check if mandatory relationship is needed for non-patron guarantor

This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed.

Test plan:
1) Add relationship as mandatory field
2) Add a child patron
3) See that the non-patron guarantor relationship is mandatory
4) Apply the patch
5) Add a child patron
6) See that the non-patron guarantor relationship is not mandatory
7) Fill a surname for the non-patron guarantor
8) See that the non-patron guarantor relationship turns mandatory

Sponsored-by: Koha-Suomi Oy
Comment 2 Jonathan Druart 2024-11-07 08:56:44 UTC
Why not applying the same trigger for #contactfirstname?

I'd say if at least one of them (#contactname or #contactfirstname) is not empty then the relationship must be required.
Comment 3 Johanna Räisä 2024-11-07 09:20:12 UTC
(In reply to Jonathan Druart from comment #2)
> Why not applying the same trigger for #contactfirstname?
> 
> I'd say if at least one of them (#contactname or #contactfirstname) is not
> empty then the relationship must be required.

Yes, should be check that also. I fill fix that and add a patch
Comment 4 Johanna Räisä 2024-11-07 11:47:49 UTC
Created attachment 174118 [details] [review]
Bug 38373: check if mandatory relationship is needed for non-patron guarantor

This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed.

Test plan:
1) Add relationship as mandatory field
2) Add a child patron
3) See that the non-patron guarantor relationship is mandatory
4) Apply the patch
5) Add a child patron
6) See that the non-patron guarantor relationship is not mandatory
7) Fill surname or first name for the non-patron guarantor
8) See that the non-patron guarantor relationship turns mandatory

Sponsored-by: Koha-Suomi Oy
Comment 5 Jesse Maseto 2025-04-02 09:22:56 UTC
Patch does not apply. Merge conflicts.
Comment 6 Johanna Räisä 2025-04-16 07:59:41 UTC
Created attachment 181000 [details] [review]
Bug 38373: check if mandatory relationship is needed for  non-patron guarantor

This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed.

Test plan:
1) Add relationship as mandatory field
2) Add a child patron
3) See that the non-patron guarantor relationship is mandatory
4) Apply the patch
5) Add a child patron
6) See that the non-patron guarantor relationship is not mandatory
7) Fill surname or first name for the non-patron guarantor
8) See that the non-patron guarantor relationship turns mandatory

Sponsored-by: Koha-Suomi Oy
Comment 7 Lin Wei 2025-05-12 13:37:38 UTC
# Results before Applying Patch

- Added "Relationship" to "BorrowerMandatoryField" in "Koha administration." 
- When trying to Add patron (kid), Non-patron guarantor > Relationship is "Required."

# Results after Applying Patch

- When trying to Add patron (kid), Non-patron guarantor > Relationship remains "Required."