When relationship is a mandatory the field has to be selected twice, for non-patron guarantor and patron guarantor. There should be a some kind of check which input fields are filled and the relationship requirement is based on that.
Created attachment 174102 [details] [review] Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill a surname for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy
Why not applying the same trigger for #contactfirstname? I'd say if at least one of them (#contactname or #contactfirstname) is not empty then the relationship must be required.
(In reply to Jonathan Druart from comment #2) > Why not applying the same trigger for #contactfirstname? > > I'd say if at least one of them (#contactname or #contactfirstname) is not > empty then the relationship must be required. Yes, should be check that also. I fill fix that and add a patch
Created attachment 174118 [details] [review] Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy
Patch does not apply. Merge conflicts.
Created attachment 181000 [details] [review] Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy
# Results before Applying Patch - Added "Relationship" to "BorrowerMandatoryField" in "Koha administration." - When trying to Add patron (kid), Non-patron guarantor > Relationship is "Required." # Results after Applying Patch - When trying to Add patron (kid), Non-patron guarantor > Relationship remains "Required."