Summary: | ILL Standard form does not consider id in openURL | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | f.demians, jonathan.druart, lucas, martin.renvoize, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38276 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This update will recognize the 'id' parameter in an openURL as a 'DOI', ensuring compatibility with version 0.1 of the OpenURL format standard. For more information, visit: https://www.doi.org/the-identifier/resources/factsheets/doi-system-and-openurl.
|
Version(s) released in: |
24.11.00
|
Circulation function: | |||
Attachments: |
Bug 38376: Add id to openURL as DOI
Bug 38376: Add id to openURL as DOI Bug 38376: Add id to openURL as DOI |
Description
Pedro Amorim
2024-11-06 11:29:19 UTC
Created attachment 174073 [details] [review] Bug 38376: Add id to openURL as DOI Test plan: 1) Enable ILLModule 2) Login on OPAC (if you haven't already) 3) Access the following openURL link: localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&id=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58 4) Notice the 'id' is considered a custom field, and is not converted into the DOI native field. 5) Apply patch. Restart plack. Repeat 4. Notice the native field is populated and a custom field entry no longer exists. Created attachment 174099 [details] [review] Bug 38376: Add id to openURL as DOI Test plan: 1) Enable ILLModule 2) Login on OPAC (if you haven't already) 3) Access the following openURL link: localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&id=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58 4) Notice the 'id' is considered a custom field, and is not converted into the DOI native field. 5) Apply patch. Restart plack. Repeat 4. Notice the native field is populated and a custom field entry no longer exists. Signed-off-by: David Nind <david@davidnind.com> Created attachment 174286 [details] [review] Bug 38376: Add id to openURL as DOI Test plan: 1) Enable ILLModule 2) Login on OPAC (if you haven't already) 3) Access the following openURL link: localhost:8080/cgi-bin/koha/opac-illrequests.pl?atitle=Music%20in%20an%20Emergent%20History%20of%20Psychology.&aulast=Klempe%20SH&backend=Standard&cardnumber=kohaadmin&custom_field=example1&date=2024&id=10.1007%2Fs12124-023-09778-9&genre=article&issn=19363567&issue=1&custom_field2=example2&method=create&opac=1&openurl=1&pages=1-11&spage=1&title=Integrative%20psychological%20%26%20behavioral%20science&volume=58 4) Notice the 'id' is considered a custom field, and is not converted into the DOI native field. 5) Apply patch. Restart plack. Repeat 4. Notice the native field is populated and a custom field entry no longer exists. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Should we consider this a bug instead of enh? (In reply to Katrin Fischer from comment #4) > Should we consider this a bug instead of enh? Categorized as enhancement as it's adding support to an older way of passing the DOI through openURL, but I don't feel strongly either way. Pushed for 24.11! Well done everyone, thank you! Not needed in 24.05.x |