| Summary: | Fix other instances of obsolete col-*-offset classes from templates | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to main --- | QA Contact: | Aleisha Amohia <aleisha> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aleisha, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35402 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates Bug 38380: Fix other instances of obsolete col-*-offset classes from templates |
||
|
Description
Owen Leonard
2024-11-06 16:30:27 UTC
Created attachment 174082 [details] [review] Bug 38380: Fix other instances of obsolete col-*-offset classes from templates This patch corrects a few remaining instances of obsolete col-*-offset classes from a few different templates. To test, apply the patch and make sure you have the system preferences AllowCheckoutNotes and ArticleRequests. - Go to Circulation -> Article requests. If necessary, create an article request. - From the list of requests, click Actions -> Cancel request. The "Confirm deletion" modal form should be well-formatted. - From the list of requests, under the "New" tab, click a record title to view the details for that article request. - In the list of patron requests, click the "X" to delete the request. The "Confirm deletion" modal form should be well-formatted. - Log into the OPAC as a user with checkouts. On your summary page, under the "Checked out" tab, click the "Add note" button and save a new note. - Go to Circulation -> Checkout notes. The layout should look correct. Toggle the CircSidebar system preference and reload the checkout notes page. It should still look correct. - The last change, to the patron clubs template page, only modifies a comment. Created attachment 174289 [details] [review] Bug 38380: Fix other instances of obsolete col-*-offset classes from templates This patch corrects a few remaining instances of obsolete col-*-offset classes from a few different templates. To test, apply the patch and make sure you have the system preferences AllowCheckoutNotes and ArticleRequests. - Go to Circulation -> Article requests. If necessary, create an article request. - From the list of requests, click Actions -> Cancel request. The "Confirm deletion" modal form should be well-formatted. - From the list of requests, under the "New" tab, click a record title to view the details for that article request. - In the list of patron requests, click the "X" to delete the request. The "Confirm deletion" modal form should be well-formatted. - Log into the OPAC as a user with checkouts. On your summary page, under the "Checked out" tab, click the "Add note" button and save a new note. - Go to Circulation -> Checkout notes. The layout should look correct. Toggle the CircSidebar system preference and reload the checkout notes page. It should still look correct. - The last change, to the patron clubs template page, only modifies a comment. Signed-off-by: David Nind <david@davidnind.com> Created attachment 174655 [details] [review] Bug 38380: Fix other instances of obsolete col-*-offset classes from templates This patch corrects a few remaining instances of obsolete col-*-offset classes from a few different templates. To test, apply the patch and make sure you have the system preferences AllowCheckoutNotes and ArticleRequests. - Go to Circulation -> Article requests. If necessary, create an article request. - From the list of requests, click Actions -> Cancel request. The "Confirm deletion" modal form should be well-formatted. - From the list of requests, under the "New" tab, click a record title to view the details for that article request. - In the list of patron requests, click the "X" to delete the request. The "Confirm deletion" modal form should be well-formatted. - Log into the OPAC as a user with checkouts. On your summary page, under the "Checked out" tab, click the "Add note" button and save a new note. - Go to Circulation -> Checkout notes. The layout should look correct. Toggle the CircSidebar system preference and reload the checkout notes page. It should still look correct. - The last change, to the patron clubs template page, only modifies a comment. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Pushed for 24.11! Well done everyone, thank you! |