Bug 38380 - Fix other instances of obsolete col-*-offset classes from templates
Summary: Fix other instances of obsolete col-*-offset classes from templates
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Aleisha Amohia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-06 16:30 UTC by Owen Leonard
Modified: 2024-11-18 16:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates (11.50 KB, patch)
2024-11-06 16:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates (11.54 KB, patch)
2024-11-08 19:22 UTC, David Nind
Details | Diff | Splinter Review
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates (11.61 KB, patch)
2024-11-18 00:49 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-11-06 16:30:27 UTC
circ/article-requests.tt
circ/checkout-notes.tt
circ/request-article.tt
clubs/templates-add-modify.tt
Comment 1 Owen Leonard 2024-11-06 16:47:54 UTC
Created attachment 174082 [details] [review]
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates

This patch corrects a few remaining instances of obsolete col-*-offset
classes from a few different templates.

To test, apply the patch and make sure you have the system preferences
AllowCheckoutNotes and ArticleRequests.

- Go to Circulation -> Article requests. If necessary, create an article
  request.
  - From the list of requests, click Actions -> Cancel request. The
    "Confirm deletion" modal form should be well-formatted.
  - From the list of requests, under the "New" tab, click a record
    title to view the details for that article request.
    - In the list of patron requests, click the "X" to delete the
      request. The "Confirm deletion" modal form should be
      well-formatted.
- Log into the OPAC as a user with checkouts. On your summary page,
  under the "Checked out" tab, click the "Add note" button and save a
  new note.
- Go to Circulation -> Checkout notes. The layout should look correct.
  Toggle the CircSidebar system preference and reload the checkout notes
  page. It should still look correct.
- The last change, to the patron clubs template page, only modifies a
  comment.
Comment 2 David Nind 2024-11-08 19:22:23 UTC
Created attachment 174289 [details] [review]
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates

This patch corrects a few remaining instances of obsolete col-*-offset
classes from a few different templates.

To test, apply the patch and make sure you have the system preferences
AllowCheckoutNotes and ArticleRequests.

- Go to Circulation -> Article requests. If necessary, create an article
  request.
  - From the list of requests, click Actions -> Cancel request. The
    "Confirm deletion" modal form should be well-formatted.
  - From the list of requests, under the "New" tab, click a record
    title to view the details for that article request.
    - In the list of patron requests, click the "X" to delete the
      request. The "Confirm deletion" modal form should be
      well-formatted.
- Log into the OPAC as a user with checkouts. On your summary page,
  under the "Checked out" tab, click the "Add note" button and save a
  new note.
- Go to Circulation -> Checkout notes. The layout should look correct.
  Toggle the CircSidebar system preference and reload the checkout notes
  page. It should still look correct.
- The last change, to the patron clubs template page, only modifies a
  comment.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Aleisha Amohia 2024-11-18 00:49:18 UTC
Created attachment 174655 [details] [review]
Bug 38380: Fix other instances of obsolete col-*-offset classes from templates

This patch corrects a few remaining instances of obsolete col-*-offset
classes from a few different templates.

To test, apply the patch and make sure you have the system preferences
AllowCheckoutNotes and ArticleRequests.

- Go to Circulation -> Article requests. If necessary, create an article
  request.
  - From the list of requests, click Actions -> Cancel request. The
    "Confirm deletion" modal form should be well-formatted.
  - From the list of requests, under the "New" tab, click a record
    title to view the details for that article request.
    - In the list of patron requests, click the "X" to delete the
      request. The "Confirm deletion" modal form should be
      well-formatted.
- Log into the OPAC as a user with checkouts. On your summary page,
  under the "Checked out" tab, click the "Add note" button and save a
  new note.
- Go to Circulation -> Checkout notes. The layout should look correct.
  Toggle the CircSidebar system preference and reload the checkout notes
  page. It should still look correct.
- The last change, to the patron clubs template page, only modifies a
  comment.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 4 Katrin Fischer 2024-11-18 16:45:58 UTC
Pushed for 24.11!

Well done everyone, thank you!