Description
Chris Cormack
2010-05-21 01:15:39 UTC
Still valid, changing version to master. *** Bug 3843 has been marked as a duplicate of this bug. *** Created attachment 68635 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Created attachment 68636 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Created attachment 68637 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Created attachment 68638 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Created attachment 68806 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> I started looking at this yesterday and was wondering why the framework was sometimes mandatory and sometimes optional. Also: I think we could choose nicer defaults for the ACQ framework, like setting default for not for loan to -1 = on order and remove some fields from display that are very unlikely to be set on order time. Should I open a separate bug report for those suggestions? I think -1 would be really nice to have, otherwise it's just the same as now, but witout the helpful warning on how to change things. I think a first step would be to have a ACQ framework that does not introduce regression and remove the warning message. This is what does the patch. The need here was bug 19289. If ACQ needs to be improved/tweaked, I think it should be done on a separate bug report (maybe it will depend on the MARC flavour, languages, etc.?) Created attachment 69057 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Created attachment 69138 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to stable for 17.11.01 Created attachment 73947 [details] [review] Bug 3841: (follow-up) Add the ACQ framework for pl-PL No idea why I missed pl-PL! (In reply to Jonathan Druart from comment #14) > Created attachment 73947 [details] [review] [review] > Bug 3841: (follow-up) Add the ACQ framework for pl-PL > > No idea why I missed pl-PL! Pushed to master for 18.05 Pushed to stable for 17.11.06 Awesome work all! Not in 17.05.x |