Bug 38429

Summary:	Ambiguous patron category when adding a new guarantee
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Patrons	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	Signed Off ---	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, laura
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 38429: Add dropdown to Add gaurantee button if multiple categories are allowed Bug 38429: Add dropdown to Add gaurantee button if multiple categories are allowed

Description Lucas Gass (lukeg) 2024-11-12 20:43:16 UTC

To recreate:
1. Have multiple patron categories that are set to 'Can be guarantee'.
2. Go to a patron record and click '+ Add guarantee'
3. Look at how the patron category is set.
4. It defaults to the first one alphabetically, by code.

In step 2, I think we need a dropdown that would prompt staff to choose the correct category.

Comment 1 Lucas Gass (lukeg) 2024-11-12 22:03:04 UTC

Created attachment 174440 [details] [review]
Bug 38429: Add dropdown to Add gaurantee button if multiple categories are allowed

To test:
1. Have multiple patron categories that are set to 'Can be guarantee'.
2. Go to a patron record and click '+ Add guarantee'
3. Look at how the patron category is set.
4. It defaults to the first one alphabetically, by code.
5. APPLY PATCH
6. Try steps 1 -2 again, this time you should get a dropdown to pick which category of guarantee you want.
7. Add some patron categories that can be gaurantees with library limitations. Make sure they only show for the correct libraries.
8. Set only patron category to be a gaurantee. The dropdown should now be a button.

Comment 2 ByWater Sandboxes 2024-11-19 21:22:24 UTC

Created attachment 174812 [details] [review]
Bug 38429: Add dropdown to Add gaurantee button if multiple categories are allowed

To test:
1. Have multiple patron categories that are set to 'Can be guarantee'.
2. Go to a patron record and click '+ Add guarantee'
3. Look at how the patron category is set.
4. It defaults to the first one alphabetically, by code.
5. APPLY PATCH
6. Try steps 1 -2 again, this time you should get a dropdown to pick which category of guarantee you want.
7. Add some patron categories that can be gaurantees with library limitations. Make sure they only show for the correct libraries.
8. Set only patron category to be a gaurantee. The dropdown should now be a button.

Signed-off-by: Laura ONeil <laura@bywatersolutions.com>