Bug 39244 - Duplicate and change password buttons missing if no borrowerRelationship defined and patron is not adult
Summary: Duplicate and change password buttons missing if no borrowerRelationship defi...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 38429
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-04 21:08 UTC by Lisette Scheer
Modified: 2025-04-11 17:05 UTC (History)
8 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00, 24.11.03
Circulation function:


Attachments
Bug 39244: Fix display of change password/duplicate buttons (2.14 KB, patch)
2025-03-04 23:00 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 39244: Fix display of change password/duplicate buttons (2.19 KB, patch)
2025-03-05 15:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39244: Fix display of change password/duplicate buttons (2.25 KB, patch)
2025-03-10 12:06 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lisette Scheer 2025-03-04 21:08:27 UTC
If  borrowerRelationship  is empty the "Duplicate" and "change Password" buttons don't show after the patch from Bug 38429 on both 24.11.x and main
Comment 1 Lucas Gass (lukeg) 2025-03-04 23:00:56 UTC
Created attachment 178947 [details] [review]
Bug 39244: Fix display of change password/duplicate buttons

To test:
1. Make or find some patron categoies that are not adult category type.
2. On patron pages notice that the Change password and duplicate buttons are missing from the toolbar.
3. APPLY PATCH
4. Try again, this time the pChange password and duplicate buttons should appear.
5. Make sure the 'Add guarantee' buttons still work.
Comment 2 Owen Leonard 2025-03-05 15:56:20 UTC
Created attachment 178993 [details] [review]
Bug 39244: Fix display of change password/duplicate buttons

To test:
1. Make or find some patron categoies that are not adult category type.
2. On patron pages notice that the Change password and duplicate
   buttons are missing from the toolbar.
3. APPLY PATCH
4. Try again, this time the pChange password and duplicate buttons
   should appear.
5. Make sure the 'Add guarantee' buttons still work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2025-03-10 12:06:24 UTC
Created attachment 179104 [details] [review]
Bug 39244: Fix display of change password/duplicate buttons

To test:
1. Make or find some patron categoies that are not adult category type.
2. On patron pages notice that the Change password and duplicate
   buttons are missing from the toolbar.
3. APPLY PATCH
4. Try again, this time the pChange password and duplicate buttons
   should appear.
5. Make sure the 'Add guarantee' buttons still work.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2025-03-13 09:30:16 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Todd Goatley 2025-03-13 23:27:55 UTC
Respectfully request to have this backported to 24.11. Thank you
Comment 6 Paul Derscheid 2025-03-19 23:18:53 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03