Summary: | Cannot schedule a curbside pickup | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to stable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | alexbuckley, david, gmcharlt, katrin.fischer, m.de.rooy, martin.renvoize, pedro.amorim |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This removes duplicated JavaScript library includes from the curbside pickup page, as they are now included in the main include. (This is a follow-up to bug 36454 - Provide indication if a patron is expired or restricted on patron search autocomplete, a new feature added in Koha 24.11.00.)
|
|
Version(s) released in: |
25.05.00, 24.11.02
|
Circulation function: | |
Bug Depends on: | 36454 | ||
Bug Blocks: | |||
Attachments: |
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete |
Description
Jonathan Druart
2024-11-16 07:17:49 UTC
Created attachment 174661 [details] [review] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed This is fixed by the follow-up in bug 36454: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36454&attachment=174671 Can't reproduce the issue after applying the patch from there. (In reply to Pedro Amorim from comment #2) > This is fixed by the follow-up in bug 36454: > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. > html&bug=36454&attachment=174671 > > Can't reproduce the issue after applying the patch from there. Yes, but it is still "valid" in the sense that the patch removes 2 includes that are already included. No longer critical however. New test plan: confirm that the curbide pickup module is still working correctly, ie. you can schedule a new pickup. Created attachment 175041 [details] [review] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Curbside pickup continues to work as expected. Created attachment 175442 [details] [review] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! not backporting to 24.05.x unless requested - dependency not in 24.05 This was pushed for 24.11.02 |