Bug 38465 - Cannot schedule a curbside pickup
Summary: Cannot schedule a curbside pickup
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 36454
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-16 07:17 UTC by Jonathan Druart
Modified: 2025-02-20 20:56 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes duplicated JavaScript library includes from the curbside pickup page, as they are now included in the main include. (This is a follow-up to bug 36454 - Provide indication if a patron is expired or restricted on patron search autocomplete, a new feature added in Koha 24.11.00.)
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete (1.54 KB, patch)
2024-11-18 08:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete (1.59 KB, patch)
2024-12-01 17:11 UTC, David Nind
Details | Diff | Splinter Review
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete (1.69 KB, patch)
2024-12-13 10:24 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-11-16 07:17:49 UTC
When searching for patron the autocomplete code raised a JS error in the console:

Uncaught TypeError: m.tz is not a function
Comment 1 Jonathan Druart 2024-11-18 08:40:49 UTC
Created attachment 174661 [details] [review]
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete

js-date-format.inc already include those 2 JS files. If had them in
curbside pickups template because it was the first using dayjs.
Now it's included in js_includes.inc.

Test plan:
Configure curbside pickup for your library and go to circ/curbside_pickups.pl
Last tab, search for a patron
Without this patch you get a JS error:
 Uncaught TypeError: m.tz is not a function
With this patch applied the patron autocomplete is fixed
Comment 2 Pedro Amorim 2024-11-18 12:43:34 UTC
This is fixed by the follow-up in bug 36454:
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36454&attachment=174671

Can't reproduce the issue after applying the patch from there.
Comment 3 Jonathan Druart 2024-11-18 12:49:52 UTC
(In reply to Pedro Amorim from comment #2)
> This is fixed by the follow-up in bug 36454:
> https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.
> html&bug=36454&attachment=174671
> 
> Can't reproduce the issue after applying the patch from there.

Yes, but it is still "valid" in the sense that the patch removes 2 includes that are already included.
Comment 4 Jonathan Druart 2024-11-18 12:50:35 UTC
No longer critical however.

New test plan: confirm that the curbide pickup module is still working correctly, ie. you can schedule a new pickup.
Comment 5 David Nind 2024-12-01 17:11:54 UTC
Created attachment 175041 [details] [review]
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete

js-date-format.inc already include those 2 JS files. If had them in
curbside pickups template because it was the first using dayjs.
Now it's included in js_includes.inc.

Test plan:
Configure curbside pickup for your library and go to circ/curbside_pickups.pl
Last tab, search for a patron
Without this patch you get a JS error:
 Uncaught TypeError: m.tz is not a function
With this patch applied the patron autocomplete is fixed

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2024-12-01 17:13:02 UTC
Testing notes (using KTD):

1. Curbside pickup continues to work as expected.
Comment 7 Marcel de Rooy 2024-12-13 10:24:31 UTC
Created attachment 175442 [details] [review]
Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete

js-date-format.inc already include those 2 JS files. If had them in
curbside pickups template because it was the first using dayjs.
Now it's included in js_includes.inc.

Test plan:
Configure curbside pickup for your library and go to circ/curbside_pickups.pl
Last tab, search for a patron
Without this patch you get a JS error:
 Uncaught TypeError: m.tz is not a function
With this patch applied the patron autocomplete is fixed

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Katrin Fischer 2024-12-23 09:37:33 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 9 Alex Buckley 2025-02-20 20:56:04 UTC
not backporting to 24.05.x unless requested - dependency not in 24.05