When searching for patron the autocomplete code raised a JS error in the console: Uncaught TypeError: m.tz is not a function
Created attachment 174661 [details] [review] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed
This is fixed by the follow-up in bug 36454: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=36454&attachment=174671 Can't reproduce the issue after applying the patch from there.
(In reply to Pedro Amorim from comment #2) > This is fixed by the follow-up in bug 36454: > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. > html&bug=36454&attachment=174671 > > Can't reproduce the issue after applying the patch from there. Yes, but it is still "valid" in the sense that the patch removes 2 includes that are already included.
No longer critical however. New test plan: confirm that the curbide pickup module is still working correctly, ie. you can schedule a new pickup.
Created attachment 175041 [details] [review] Bug 38465: (bug 36454 follow-up) Fix curbside pickup's patron autocomplete js-date-format.inc already include those 2 JS files. If had them in curbside pickups template because it was the first using dayjs. Now it's included in js_includes.inc. Test plan: Configure curbside pickup for your library and go to circ/curbside_pickups.pl Last tab, search for a patron Without this patch you get a JS error: Uncaught TypeError: m.tz is not a function With this patch applied the patron autocomplete is fixed Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Curbside pickup continues to work as expected.