Description
Jonathan Druart
2024-11-18 13:53:03 UTC
Created attachment 177260 [details] [review] Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Created attachment 177276 [details] [review] Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 177277 [details] [review] Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. Created attachment 177308 [details] [review] Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 177309 [details] [review] Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Before applying the patches (and without the dependencies), use the 'Export' option for these tables: . Administration > Patrons and circulation > Patron categories . Administration > Patrons and circulation > Patron restriction types . Acquisitions > [Vendor] > [A basket for a vendor with an order] (You need to add an order to a basket) 2. Look at the columns exported in the files and compare to the columns shown in the browser for the tables - they don't match up. 3. Apply the patches (and dependencies). 4. Refresh the pages and export the tables again. 5. Note that: - The columns in the exported files match what is shown for the tables - The columns you would expect to be exported are exported, and columns such as Actions (Patron categories and Patron restriction types) or Place hold, Modify and Cancel order (for a basket) are not. Created attachment 177322 [details] [review] Bug 38472: Remove kohaTable's exportColumns option We hardcode the id of the columns to export, we should use .noExport instead on the columns we do not want to export. Test plan: Confirm that the columns exported on the acqui/basket, admin/categories and admin/restrictions pages are the same with and without this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 177323 [details] [review] Bug 38472: (follow-up) Adding and removing a few noExport classes I think only the "Actions" column on the restrictions page should be excluded from export. On the acquisitions basket page we need it on the "Place hold" column. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> PQA here, but I will also set to BLOCKED until the dependencies can move. I signed off on both of them, so cannot QA. |