Bug 38484

Summary: Filters on the "Holds to pull" page is broken
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Jonathan Druart <jonathan.druart>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: emily.lamancusa, gmcharlt
Version: unspecifiedKeywords: rel_24_11_candidate, RM_priority
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36640    
Bug Blocks:    
Attachments: Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull"
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull"

Description Jonathan Druart 2024-11-19 12:37:40 UTC
Has been broken by bug 36640.
Comment 1 Jonathan Druart 2024-11-19 12:42:15 UTC
Created attachment 174788 [details] [review]
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull"

On "Bug 36640: Remove fnAddFilters" I assume that it was only used for
debounce. But actually it was used on this table to add filtering.

This patch adjusts how we deal with the filters on this table, reusing
the standard "add_filters" and "filters_options" parameters of
KohaTable.

It also passes the DT object allowing to use DT's api. Here it is
useful to retrieve the data in the column.
Comment 2 Emily Lamancusa (emlam) 2024-11-19 18:49:53 UTC
Created attachment 174806 [details] [review]
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull"

On "Bug 36640: Remove fnAddFilters" I assume that it was only used for
debounce. But actually it was used on this table to add filtering.

This patch adjusts how we deal with the filters on this table, reusing
the standard "add_filters" and "filters_options" parameters of
KohaTable.

It also passes the DT object allowing to use DT's api. Here it is
useful to retrieve the data in the column.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>