Bug 38484 - Filters on the "Holds to pull" page is broken
Summary: Filters on the "Holds to pull" page is broken
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_24_11_candidate, RM_priority
Depends on: 36640
Blocks:
  Show dependency tree / graph
 
Reported: 2024-11-19 12:37 UTC by Jonathan Druart
Modified: 2024-11-19 18:50 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull" (6.01 KB, patch)
2024-11-19 12:42 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull" (6.08 KB, patch)
2024-11-19 18:49 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-11-19 12:37:40 UTC 
Has been broken by bug 36640.
Comment 1 Jonathan Druart 2024-11-19 12:42:15 UTC 
Created attachment 174788 [details] [review]
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull"

On "Bug 36640: Remove fnAddFilters" I assume that it was only used for
debounce. But actually it was used on this table to add filtering.

This patch adjusts how we deal with the filters on this table, reusing
the standard "add_filters" and "filters_options" parameters of
KohaTable.

It also passes the DT object allowing to use DT's api. Here it is
useful to retrieve the data in the column.
Comment 2 Emily Lamancusa (emlam) 2024-11-19 18:49:53 UTC 
Created attachment 174806 [details] [review]
Bug 38484: (bug 36640 follow-up) Fix filters on "Holds to pull"

On "Bug 36640: Remove fnAddFilters" I assume that it was only used for
debounce. But actually it was used on this table to add filtering.

This patch adjusts how we deal with the filters on this table, reusing
the standard "add_filters" and "filters_options" parameters of
KohaTable.

It also passes the DT object allowing to use DT's api. Here it is
useful to retrieve the data in the column.

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>