Bug 38499

Summary: Remove unused "note" argument to HTML::Scrubber
Product: Koha Reporter: David Cook <dcook>
Component: Architecture, internals, and plumbingAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: martin.renvoize
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40079
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 36328    
Bug Blocks:    

Description David Cook 2024-11-20 23:03:36 UTC
It looks like bug 36328 accidentally added a "note" parameter to HTML::Scrubber in C4::Scrubber.

Looking at the HTML::Scrubber documentation, there is no "note" parameter. It looks like a bit of confusion because "comment" is both a HTML::Scrubber parameter and a C4::Scrubber type.
Comment 1 Martin Renvoize (ashimema) 2025-06-05 10:27:22 UTC
I inlined a fix for this in bug 40079
Comment 2 Martin Renvoize (ashimema) 2025-06-05 10:27:41 UTC

*** This bug has been marked as a duplicate of bug 40079 ***
Comment 3 David Cook 2025-06-06 01:44:03 UTC
(In reply to Martin Renvoize (ashimema) from comment #1)
> I inlined a fix for this in bug 40079

You're the best :3