Bug 38499 - Remove unused "note" argument to HTML::Scrubber
Summary: Remove unused "note" argument to HTML::Scrubber
Status: RESOLVED DUPLICATE of bug 40079
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 36328
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-20 23:03 UTC by David Cook
Modified: 2025-06-06 01:44 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2024-11-20 23:03:36 UTC
It looks like bug 36328 accidentally added a "note" parameter to HTML::Scrubber in C4::Scrubber.

Looking at the HTML::Scrubber documentation, there is no "note" parameter. It looks like a bit of confusion because "comment" is both a HTML::Scrubber parameter and a C4::Scrubber type.
Comment 1 Martin Renvoize (ashimema) 2025-06-05 10:27:22 UTC
I inlined a fix for this in bug 40079
Comment 2 Martin Renvoize (ashimema) 2025-06-05 10:27:41 UTC

*** This bug has been marked as a duplicate of bug 40079 ***
Comment 3 David Cook 2025-06-06 01:44:03 UTC
(In reply to Martin Renvoize (ashimema) from comment #1)
> I inlined a fix for this in bug 40079

You're the best :3