Summary: | Budget Planning Pages Need Design Work | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, henridamien |
Version: | rel_3_2 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 3975 | ||
Attachments: |
Incremental fix
Screenshot detail of current interface Screenshot of proposed interface change Follow-up patch Screenshot of additional change Revised for current HEAD Revised for current HEAD |
Description
Chris Cormack
2010-05-21 01:15:45 UTC
Created attachment 2226 [details] [review] Incremental fix A minor change to begin addressing this bug: The template was double-including some JS and CSS dependencies. Created attachment 2227 [details]
Screenshot detail of current interface
There is functionality in this interface which I think it too difficult to discover in the current design. Shown in this screenshot, the "-" next to each branch code is a clickable control to hide that column. The symbol is not highlighted as a link and isn't styled to change the cursor from the standard text caret. Without such clues the user has little chance of discovering the option of hiding a column.
The same is true of the "+" in the last table header cell. Clicking it brings up a menu of table columns which can be shown, to be used if you have hidden something you want to see again. But there is not way of intuiting that from the appearance of it.
Created attachment 2228 [details]
Screenshot of proposed interface change
This screenshot shows how I propose to change the interface: The minimal "-" symbols have been expanded into text links and moved to their own column. This adds both discoverability (it's more clear what their purpose is) and clickability (it's much easier to click the larger target). In addition, title attributes offer a hint, "Hide this column."
Similarly, the "+" control has been expanded to a link, "show a column."
This screenshot also shows a change which moves the filter form into the left-hand sidebar following existing page layout patterns.
That makes things much clearer - I didn't know about that functionality until I read your bug report :) I like the proposed interface. I also note another minor usability problem - showing the currency symbol instead of the currency name or code is not ideal; consider what would happen to a library who deals with both USD and CAD. Created attachment 2277 [details] [review] Follow-up patch The currency symbol issue has it's own bug report now: Bug 4913. A patch has been submitted. Created attachment 2278 [details]
Screenshot of additional change
Follow-up patch includes the addition of a "locked" icon for locked funds.
Pushed to new/enh/bug_3850
I had a conflict when applying this patch in the file
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl
At around line 109
<<<<<<< HEAD
<!-- TMPL_INCLUDE NAME="budgets-active-currency.inc" -->
=======
>>>>>>> More comprehensive fixes for Bug 3850 - Budget Planning Pages Need Design Work
I resolved it to keep the include, but that may have been the wrong move, please take a look at this branch and tell me if that was right.
Created attachment 2808 [details] [review] Revised for current HEAD This bug is mentioned in: More comprehensive fixes for Bug 3850 - Budget Planning Pages Need Design Work http://lists.koha-community.org/pipermail/koha-patches/2010-November/012961.html bug 3850 followup - tweaks http://lists.koha-community.org/pipermail/koha-patches/2010-November/012960.html Im currently a bit confused here. http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog;h=refs/heads/new/enh/bug_3850 Is the current state of the branch, the latest patch submitted obviously will conflict all over that. Should I reset back the last 2 commits, and just apply your one new patch owen? What about Galens follow up? This bug is mentioned in: Revised fix for Bug 3850 - Budget Planning Pages Need Design Work http://lists.koha-community.org/pipermail/koha-patches/2010-December/013173.html Revised fix for Bug 3850 - Budget Planning Pages Need Design Work http://lists.koha-community.org/pipermail/koha-patches/2010-December/013228.html Still need an answer on this. Created attachment 3042 [details] [review] Revised for current HEAD This patch includes the corrections from and should be used in place of the changes in new/enh/bug_3850 Merged, please test this is fixed, I see another graphical annoyance that I'll report in a new bug/enhancement. |