Bug 3850 - Budget Planning Pages Need Design Work
Summary: Budget Planning Pages Need Design Work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 3975
  Show dependency treegraph
 
Reported: 2009-12-03 05:22 UTC by Nicole C. Engard
Modified: 2012-10-25 23:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Incremental fix (1.98 KB, patch)
2010-06-08 16:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot detail of current interface (3.05 KB, image/png)
2010-06-08 16:24 UTC, Owen Leonard
Details
Screenshot of proposed interface change (22.85 KB, image/png)
2010-06-08 16:30 UTC, Owen Leonard
Details
Follow-up patch (18.71 KB, patch)
2010-06-28 14:03 UTC, Owen Leonard
Details | Diff | Splinter Review
Screenshot of additional change (11.06 KB, image/png)
2010-06-28 14:09 UTC, Owen Leonard
Details
Revised for current HEAD (16.08 KB, patch)
2010-12-06 15:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Revised for current HEAD (17.07 KB, patch)
2011-01-31 16:03 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:15:45 UTC


---- Reported by nengard@gmail.com 2009-12-03 17:22:08 ----

The pages under budget planning are a bit cramped and could use the magic touch of owen :) to make them a bit easier to read

cgi-bin/koha/admin/aqplan.pl



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:15 UTC  ---

This bug was previously known as _bug_ 3850 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3850

Actual time not defined. Setting to 0.0

Comment 1 Owen Leonard 2010-06-08 16:05:36 UTC
Created attachment 2226 [details] [review]
Incremental fix

A minor change to begin addressing this bug: The template was double-including some JS and CSS dependencies.
Comment 2 Owen Leonard 2010-06-08 16:24:14 UTC
Created attachment 2227 [details]
Screenshot detail of current interface

There is functionality in this interface which I think it too difficult to discover in the current design. Shown in this screenshot, the "-" next to each branch code is a clickable control to hide that column. The symbol is not highlighted as a link and isn't styled to change the cursor from the standard text caret. Without such clues the user has little chance of discovering the option of hiding a column.

The same is true of the "+" in the last table header cell. Clicking it brings up a menu of table columns which can be shown, to be used if you have hidden something you want to see again. But there is not way of intuiting that from the appearance of it.
Comment 3 Owen Leonard 2010-06-08 16:30:00 UTC
Created attachment 2228 [details]
Screenshot of proposed interface change

This screenshot shows how I propose to change the interface: The minimal "-" symbols have been expanded into text links and moved to their own column. This adds both discoverability (it's more clear what their purpose is) and clickability (it's much easier to click the larger target). In addition, title attributes offer a hint, "Hide this column."

Similarly, the "+" control has been expanded to a link, "show a column."

This screenshot also shows a change which moves the filter form into the left-hand sidebar following existing page layout patterns.
Comment 4 Nicole C. Engard 2010-06-09 11:53:58 UTC
That makes things much clearer - I didn't know about that functionality until I read your bug report :)
Comment 5 Galen Charlton 2010-06-19 12:21:11 UTC
I like the proposed interface.  I also note another minor usability problem - showing the currency symbol instead of the currency name or code is not ideal; consider what would happen to a library who deals with both USD and CAD.
Comment 6 Owen Leonard 2010-06-28 14:03:37 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2010-06-28 14:05:09 UTC
The currency symbol issue has it's own bug report now: Bug 4913. A patch has been submitted.
Comment 8 Owen Leonard 2010-06-28 14:09:02 UTC
Created attachment 2278 [details]
Screenshot of additional change

Follow-up patch includes the addition of a "locked" icon for locked funds.
Comment 9 Chris Cormack 2010-11-15 02:21:41 UTC
Pushed to new/enh/bug_3850

I had a conflict when applying this patch in the file

koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl

At around line 109

<<<<<<< HEAD
    <!-- TMPL_INCLUDE NAME="budgets-active-currency.inc" -->
=======
>>>>>>> More comprehensive fixes for Bug 3850 - Budget Planning Pages Need Design Work

I resolved it to keep the include, but that may have been the wrong move, please take a look at this branch and tell me if that was right.
Comment 10 Owen Leonard 2010-12-06 15:38:03 UTC Comment hidden (obsolete)
Comment 11 MJ Ray (software.coop) 2010-12-10 10:23:01 UTC
This bug is mentioned in:
More comprehensive fixes	for Bug 3850 - Budget Planning Pages Need Design Work http://lists.koha-community.org/pipermail/koha-patches/2010-November/012961.html
bug 3850 followup - tweaks http://lists.koha-community.org/pipermail/koha-patches/2010-November/012960.html
Comment 12 Chris Cormack 2010-12-15 03:53:56 UTC
Im currently a bit confused here.

http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog;h=refs/heads/new/enh/bug_3850

Is the current state of the branch, the latest patch submitted obviously will conflict all over that.

Should I reset back the last 2 commits, and just apply your one new patch owen? What about Galens follow up?
Comment 13 MJ Ray (software.coop) 2011-01-06 10:17:46 UTC
This bug is mentioned in:
Revised fix for Bug 3850 - Budget Planning	Pages Need Design Work http://lists.koha-community.org/pipermail/koha-patches/2010-December/013173.html
Revised fix for Bug 3850 - Budget	Planning Pages Need Design Work http://lists.koha-community.org/pipermail/koha-patches/2010-December/013228.html
Comment 14 Chris Cormack 2011-01-29 19:11:45 UTC
Still need an answer on this.
Comment 15 Owen Leonard 2011-01-31 16:03:40 UTC
Created attachment 3042 [details] [review]
Revised for current HEAD

This patch includes the corrections from and should be used in place of the changes in new/enh/bug_3850
Comment 16 Chris Cormack 2011-02-01 06:28:36 UTC
Merged, please test
Comment 17 Nicole C. Engard 2011-02-01 13:25:10 UTC
this is fixed, I see another graphical annoyance that I'll report in a new bug/enhancement.