Summary: | Item table status column display is wrong when record has recalls | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Needs documenting --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, david, emmi.takkinen, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize, paul.derscheid, rcoert, wainuiwitikapark |
Version: | Main | Keywords: | rel_24_05_candidate |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the display of recalls in the holdings table - the "Recalled by [patron] on [date]" message now only shows for item-level recalls. Previously, the message was displayed for all items when a record-level recall was made.
|
|
Version(s) released in: |
25.05.00,24.11.02,24.05.09
|
Circulation function: | Recalls |
Bug Depends on: | |||
Bug Blocks: | 37334, 38767, 39962 | ||
Attachments: |
Bug 38512: Only show status of recall when it is item_level
Bug 38512: Fix display of recalls in items table Bug 38512: Fix display of recalls in items table Bug 38512: Fix display of recalls in items table |
Description
Lucas Gass (lukeg)
2024-11-21 22:01:36 UTC
Created attachment 174904 [details] [review] Bug 38512: Only show status of recall when it is item_level To test: 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "recalled by koha (42) on 11/21/2024". 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correcylt show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly. With this patch, If I check out all items on the record and then place a recall on the next available item there is no indication anywhere on the staff detail page that there is a 'next available' recall. I think there should be some indication of that on the record. But is the status column ( item row ) the place to do it? (In reply to Lucas Gass (lukeg) from comment #2) > With this patch, If I check out all items on the record and then place a > recall on the next available item there is no indication anywhere on the > staff detail page that there is a 'next available' recall. > > I think there should be some indication of that on the record. But is the > status column ( item row ) the place to do it? If I compare to holds, when all items are checked out and I make a bib level hold, there is no indication in the status column ( item row ) that there is a hold. So, I think this patch is correct as is. Created attachment 175057 [details] [review] Bug 38512: Fix display of recalls in items table 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "Recalled by koha (42) on 11/21/2024" 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correctly show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly. Note: There as also a problem with the display of the holding library name, I fixed that here. Created attachment 175068 [details] [review] Bug 38512: Fix display of recalls in items table 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "Recalled by koha (42) on 11/21/2024" 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correctly show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Created attachment 175571 [details] [review] Bug 38512: Fix display of recalls in items table 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "Recalled by koha (42) on 11/21/2024" 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correctly show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 25.05! Well done everyone, thank you! *** Bug 39457 has been marked as a duplicate of this bug. *** This is needed in 24.05 please :) It looks like it's already in the commit log for 24.11, though not noted here yet. Nice work everyone! This was pushed to 24.11.x for 24.11.02 Applied to 24.05.x for 24.05.09 Items table not with API in 23.11.x |