| Summary: | Generate next serial deletes the notes from the expected serial and ignores preference PreserveSerialNotes in the new serial | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Adolfo Rodríguez Taboada <adolfo.rodriguez> |
| Component: | Serials | Assignee: | Adolfo Rodríguez Taboada <adolfo.rodriguez> |
| Status: | Pushed to stable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | baptiste.wojtkowski, david, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the generation of the next serial and keeping the issue notes, when PreserveSerialNotes is set to "Do". If a serial with the status "Expected" had notes and the next issue was generated (the "Generate next" button), the serial status changed to "Late" and the notes were not copied over - as expected. However, if PreserveSerialNotes was set to "Do", it wasn't keeping the note for the next issue.
|
Version(s) released in: |
25.05.00,24.11.08
|
| Circulation function: | |||
| Attachments: |
Bug 38515: Keep serial notes when generating next serial.
Bug 38515: Keep serial notes when generating next serial. Bug 38515: Keep serial notes when generating next serial. |
||
|
Description
Adolfo Rodríguez Taboada
2024-11-22 09:40:54 UTC
Created attachment 174917 [details] [review] Bug 38515: Keep serial notes when generating next serial. This patch prevents the loss of notes in serials when generating next serial Test plan: 1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes 2 Click Generate next 3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes. 4 Apply patch, restart services 5 Edit the serial with Expected status to fill the notes field. 6 Click Generate next 7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial. Created attachment 175479 [details] [review] Bug 38515: Keep serial notes when generating next serial. This patch prevents the loss of notes in serials when generating next serial Test plan: 1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes 2 Click Generate next 3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes. 4 Apply patch, restart services 5 Edit the serial with Expected status to fill the notes field. 6 Click Generate next 7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial. Signed-off-by: David Nind <david@davidnind.com> Created attachment 177378 [details] [review] Bug 38515: Keep serial notes when generating next serial. This patch prevents the loss of notes in serials when generating next serial Test plan: 1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes 2 Click Generate next 3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes. 4 Apply patch, restart services 5 Edit the serial with Expected status to fill the notes field. 6 Click Generate next 7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! Pushed into 24.11.x for 24.11.08 nice work everyone |