Bug 38515 - Generate next serial deletes the notes from the expected serial and ignores preference PreserveSerialNotes in the new serial
Summary: Generate next serial deletes the notes from the expected serial and ignores p...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Adolfo Rodríguez Taboada
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-22 09:40 UTC by Adolfo Rodríguez Taboada
Modified: 2025-01-31 14:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the generation of the next serial and keeping the issue notes, when PreserveSerialNotes is set to "Do". If a serial with the status "Expected" had notes and the next issue was generated (the "Generate next" button), the serial status changed to "Late" and the notes were not copied over - as expected. However, if PreserveSerialNotes was set to "Do", it wasn't keeping the note for the next issue.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38515: Keep serial notes when generating next serial. (1.67 KB, patch)
2024-11-22 09:48 UTC, Adolfo Rodríguez Taboada
Details | Diff | Splinter Review
Bug 38515: Keep serial notes when generating next serial. (1.72 KB, patch)
2024-12-15 18:31 UTC, David Nind
Details | Diff | Splinter Review
Bug 38515: Keep serial notes when generating next serial. (1.81 KB, patch)
2025-01-31 10:42 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adolfo Rodríguez Taboada 2024-11-22 09:40:54 UTC
If a serial with the status Expected has notes and you click the "Generate next" button, the serial status will change to Late and the notes will be gone.
If the system preference PreserveSerialNotes is activated, it won't have any effect, as the new serial won't keep the notes from the previous serial.

This is cause by the call to the function ModSerialStatus at serials-collection.pl inside operation cud-gennext, that passes "" where the notes should go. This means that field will be deleted in the current serial with status 1 (Expected) and won't be copied to the new serial.
Comment 1 Adolfo Rodríguez Taboada 2024-11-22 09:48:36 UTC
Created attachment 174917 [details] [review]
Bug 38515: Keep serial notes when generating next serial.

This patch prevents the loss of notes in serials when generating next serial

Test plan:
1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes
2 Click Generate next
3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes.
4 Apply patch, restart services
5 Edit the serial with Expected status to fill the notes field.
6 Click Generate next
7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial.
Comment 2 David Nind 2024-12-15 18:31:47 UTC
Created attachment 175479 [details] [review]
Bug 38515: Keep serial notes when generating next serial.

This patch prevents the loss of notes in serials when generating next serial

Test plan:
1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes
2 Click Generate next
3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes.
4 Apply patch, restart services
5 Edit the serial with Expected status to fill the notes field.
6 Click Generate next
7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2025-01-31 10:42:28 UTC
Created attachment 177378 [details] [review]
Bug 38515: Keep serial notes when generating next serial.

This patch prevents the loss of notes in serials when generating next serial

Test plan:
1 Create a subscription, fill the notes field for the serial with Expected status and activate the system preference PreserveSerialNotes
2 Click Generate next
3 Check that the notes from the now Late serial are gone and that the new serial doesn't have notes.
4 Apply patch, restart services
5 Edit the serial with Expected status to fill the notes field.
6 Click Generate next
7 Check that the notes from the now Late serial are kepts and that they have been copied to the new serial.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2025-01-31 14:58:08 UTC
Pushed for 25.05!

Well done everyone, thank you!