Bug 38526

Summary: Auth_with_* tests fail randomly
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, jesse, lucas, pedro.amorim
Version: unspecifiedKeywords: rel_24_11_candidate
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Bug Depends on: 36822    
Bug Blocks:    
Attachments: Bug 38526: (bug 36822 follow-up): Improve datetime comparison in tests

Description Jonathan Druart 2024-11-25 10:58:56 UTC

    
Comment 1 Jonathan Druart 2024-11-25 11:01:45 UTC
Created attachment 174966 [details] [review]
Bug 38526: (bug 36822 follow-up): Improve datetime comparison in tests

17:39:54 koha_1       |     #   Failed test 'updated_on correctly saved on newly created user'
17:39:54 koha_1       |     #   at t/db_dependent/Auth_with_shibboleth.t line 319.
17:39:54 koha_1       |     #     Structures begin differing at:
17:39:54 koha_1       |     #          $got->[0] = '2024-11-19 16:39:30'
17:39:54 koha_1       |     #     $expected->[0] = '2024-11-19 16:39:29'
17:39:54 koha_1       |     # Looks like you failed 1 test of 54.

We must use t::lib::Dates::compare to compare datetimes in tests.
Comment 2 Katrin Fischer 2024-11-25 11:04:58 UTC
Picking an testing... for main.
Comment 3 Katrin Fischer 2024-11-25 11:05:36 UTC
Hi Pedro, please have a look here!
Comment 4 Lucas Gass (lukeg) 2024-12-05 23:15:38 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 5 Fridolin Somers 2024-12-18 13:48:30 UTC
Pushed to 23.11.x for 23.11.11
Comment 6 Jesse Maseto 2025-02-03 16:18:06 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.
Comment 7 Pedro Amorim 2025-02-03 16:47:13 UTC
(In reply to Jesse Maseto from comment #6)
> Not pushed to LTS. Marked Resolved.
> 
> If you feel this should be in LTS please reply with your reason.

This should be considered to be pushed to 23.05.x after bug 36822
Comment 8 Katrin Fischer 2025-02-03 16:50:56 UTC
(In reply to Pedro Amorim from comment #7)
> (In reply to Jesse Maseto from comment #6)
> > Not pushed to LTS. Marked Resolved.
> > 
> > If you feel this should be in LTS please reply with your reason.
> 
> This should be considered to be pushed to 23.05.x after bug 36822

23.05 is no longer maintained. We now have the situation that there is a "gap" between LTS release version and the other maintained versions.
Comment 9 Pedro Amorim 2025-02-03 16:57:44 UTC
(In reply to Katrin Fischer from comment #8)
> 23.05 is no longer maintained. We now have the situation that there is a
> "gap" between LTS release version and the other maintained versions.

Understood. If this is the case then why are we having a discussion on whether this should be on LTS or not =DDD
Comment 10 Katrin Fischer 2025-02-03 17:00:16 UTC
(In reply to Pedro Amorim from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > 23.05 is no longer maintained. We now have the situation that there is a
> > "gap" between LTS release version and the other maintained versions.
> 
> Understood. If this is the case then why are we having a discussion on
> whether this should be on LTS or not =DDD

I had a long day, so it might be me :) Jessie's comment is about 22.11 when referring to LTS.
Comment 11 Pedro Amorim 2025-02-03 17:01:30 UTC
(In reply to Katrin Fischer from comment #10)
> I had a long day, so it might be me :) Jessie's comment is about 22.11 when
> referring to LTS.

My bad, I thought LTS referred to 23.05.x! Thanks for pointing this out.