Bug 38526 - Auth_with_* tests fail randomly
Summary: Auth_with_* tests fail randomly
Status: Pushed to oldoldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_23_05_candidate, rel_23_11_candidate, rel_24_11_candidate
Depends on: 36822
Blocks:
  Show dependency tree / graph
 
Reported: 2024-11-25 10:58 UTC by Jonathan Druart
Modified: 2024-12-18 13:48 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:

Attachments
Bug 38526: (bug 36822 follow-up): Improve datetime comparison in tests (3.33 KB, patch)
2024-11-25 11:01 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-11-25 10:58:56 UTC 

    


    


      



        
          Comment 1
        

        
          Jonathan Druart

        

        
        

        
          2024-11-25 11:01:45 UTC
        

      






Created attachment 174966 [details] [review]
Bug 38526: (bug 36822 follow-up): Improve datetime comparison in tests

17:39:54 koha_1       |     #   Failed test 'updated_on correctly saved on newly created user'
17:39:54 koha_1       |     #   at t/db_dependent/Auth_with_shibboleth.t line 319.
17:39:54 koha_1       |     #     Structures begin differing at:
17:39:54 koha_1       |     #          $got->[0] = '2024-11-19 16:39:30'
17:39:54 koha_1       |     #     $expected->[0] = '2024-11-19 16:39:29'
17:39:54 koha_1       |     # Looks like you failed 1 test of 54.

We must use t::lib::Dates::compare to compare datetimes in tests.

    


    


      



        
          Comment 2
        

        
          Katrin Fischer

        

        
        

        
          2024-11-25 11:04:58 UTC
        

      






Picking an testing... for main.

    


    


      



        
          Comment 3
        

        
          Katrin Fischer

        

        
        

        
          2024-11-25 11:05:36 UTC
        

      






Hi Pedro, please have a look here!

    


    


      



        
          Comment 4
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2024-12-05 23:15:38 UTC
        

      






Backported to 24.05.x for upcoming 24.05.06

    


    


      



        
          Comment 5
        

        
          Fridolin Somers

        

        
        

        
          2024-12-18 13:48:30 UTC
        

      






Pushed to 23.11.x for 23.11.11