Created attachment 174966 [details] [review] Bug 38526: (bug 36822 follow-up): Improve datetime comparison in tests 17:39:54 koha_1 | # Failed test 'updated_on correctly saved on newly created user' 17:39:54 koha_1 | # at t/db_dependent/Auth_with_shibboleth.t line 319. 17:39:54 koha_1 | # Structures begin differing at: 17:39:54 koha_1 | # $got->[0] = '2024-11-19 16:39:30' 17:39:54 koha_1 | # $expected->[0] = '2024-11-19 16:39:29' 17:39:54 koha_1 | # Looks like you failed 1 test of 54. We must use t::lib::Dates::compare to compare datetimes in tests.
Picking an testing... for main.
Hi Pedro, please have a look here!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.
(In reply to Jesse Maseto from comment #6) > Not pushed to LTS. Marked Resolved. > > If you feel this should be in LTS please reply with your reason. This should be considered to be pushed to 23.05.x after bug 36822
(In reply to Pedro Amorim from comment #7) > (In reply to Jesse Maseto from comment #6) > > Not pushed to LTS. Marked Resolved. > > > > If you feel this should be in LTS please reply with your reason. > > This should be considered to be pushed to 23.05.x after bug 36822 23.05 is no longer maintained. We now have the situation that there is a "gap" between LTS release version and the other maintained versions.
(In reply to Katrin Fischer from comment #8) > 23.05 is no longer maintained. We now have the situation that there is a > "gap" between LTS release version and the other maintained versions. Understood. If this is the case then why are we having a discussion on whether this should be on LTS or not =DDD
(In reply to Pedro Amorim from comment #9) > (In reply to Katrin Fischer from comment #8) > > 23.05 is no longer maintained. We now have the situation that there is a > > "gap" between LTS release version and the other maintained versions. > > Understood. If this is the case then why are we having a discussion on > whether this should be on LTS or not =DDD I had a long day, so it might be me :) Jessie's comment is about 22.11 when referring to LTS.
(In reply to Katrin Fischer from comment #10) > I had a long day, so it might be me :) Jessie's comment is about 22.11 when > referring to LTS. My bad, I thought LTS referred to 23.05.x! Thanks for pointing this out.