| Summary: | Include action_logs.diff when reverting hold | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Tools | Assignee: | Andrew Fuerste-Henry <andrew> |
| Status: | Needs documenting --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | alexbuckley, david, fridolin.somers, kebliss, m.de.rooy, sam.sowanick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the holds log so that the diff now includes the changes when reverting a hold. (This was missed when the diff in JSON format feature was added to Koha 24.05 by bug 25159.).
|
Version(s) released in: |
25.05.00,24.11.02,24.05.08
|
| Circulation function: | |||
| Attachments: |
Bug 38531: add diff when reverting hold
Bug 38531: add diff when reverting hold Bug 38531: add diff when reverting hold |
||
|
Description
Andrew Fuerste-Henry
2024-11-25 20:30:48 UTC
Created attachment 174983 [details] [review] Bug 38531: add diff when reverting hold To test: 1 - place, capture, and revert a hold 2 - view action logs for your hold via SQL so you can see the diff column 3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff 4 - apply patch, restart_all 5 - capture and revert your hold again 6 - confirm logs include diff showing change to found and priority Created attachment 174984 [details] [review] Bug 38531: add diff when reverting hold To test: 1 - place, capture, and revert a hold 2 - view action logs for your hold via SQL so you can see the diff column 3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff 4 - apply patch, restart_all 5 - capture and revert your hold again 6 - confirm logs include diff showing change to found and priority Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Created attachment 175438 [details] [review] Bug 38531: add diff when reverting hold To test: 1 - place, capture, and revert a hold 2 - view action logs for your hold via SQL so you can see the diff column 3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff 4 - apply patch, restart_all 5 - capture and revert your hold again 6 - confirm logs include diff showing change to found and priority Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.01 Nice work everyone! Pushed to 24.05.x for 24.05.08 |