Bug 38531 - Include action_logs.diff when reverting hold
Summary: Include action_logs.diff when reverting hold
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-25 20:30 UTC by Andrew Fuerste-Henry
Modified: 2025-03-20 15:06 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the holds log so that the diff now includes the changes when reverting a hold. (This was missed when the diff in JSON format feature was added to Koha 24.05 by bug 25159.).
Version(s) released in:
25.05.00,24.11.02,24.05.08
Circulation function:


Attachments
Bug 38531: add diff when reverting hold (1.44 KB, patch)
2024-11-25 20:33 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38531: add diff when reverting hold (1.50 KB, patch)
2024-11-25 22:57 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38531: add diff when reverting hold (1.60 KB, patch)
2024-12-13 08:48 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-11-25 20:30:48 UTC
Bug 25159 added a diff column to action logs and made it populate for changes to holds. We missed adding that diff when reverting the hold waiting status.
Comment 1 Andrew Fuerste-Henry 2024-11-25 20:33:59 UTC
Created attachment 174983 [details] [review]
Bug 38531: add diff when reverting hold

To test:
1 - place, capture, and revert a hold
2 - view action logs for your hold via SQL so you can see the diff column
3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff
4 - apply patch, restart_all
5 - capture and revert your hold again
6 - confirm logs include diff showing change to found and priority
Comment 2 Biblibre Sandboxes 2024-11-25 22:57:38 UTC
Created attachment 174984 [details] [review]
Bug 38531: add diff when reverting hold

To test:
1 - place, capture, and revert a hold
2 - view action logs for your hold via SQL so you can see the diff column
3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff
4 - apply patch, restart_all
5 - capture and revert your hold again
6 - confirm logs include diff showing change to found and priority

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Marcel de Rooy 2024-12-13 08:48:40 UTC
Created attachment 175438 [details] [review]
Bug 38531: add diff when reverting hold

To test:
1 - place, capture, and revert a hold
2 - view action logs for your hold via SQL so you can see the diff column
3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff
4 - apply patch, restart_all
5 - capture and revert your hold again
6 - confirm logs include diff showing change to found and priority

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-12-23 08:38:20 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2025-02-03 19:09:27 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 6 Alex Buckley 2025-03-20 02:15:40 UTC
Nice work everyone!

Pushed to 24.05.x for 24.05.08
Comment 7 Fridolin Somers 2025-03-20 15:06:27 UTC
Bug 25159 not in 23.11.x