Bug 25159 added a diff column to action logs and made it populate for changes to holds. We missed adding that diff when reverting the hold waiting status.
Created attachment 174983 [details] [review] Bug 38531: add diff when reverting hold To test: 1 - place, capture, and revert a hold 2 - view action logs for your hold via SQL so you can see the diff column 3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff 4 - apply patch, restart_all 5 - capture and revert your hold again 6 - confirm logs include diff showing change to found and priority
Created attachment 174984 [details] [review] Bug 38531: add diff when reverting hold To test: 1 - place, capture, and revert a hold 2 - view action logs for your hold via SQL so you can see the diff column 3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff 4 - apply patch, restart_all 5 - capture and revert your hold again 6 - confirm logs include diff showing change to found and priority Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Created attachment 175438 [details] [review] Bug 38531: add diff when reverting hold To test: 1 - place, capture, and revert a hold 2 - view action logs for your hold via SQL so you can see the diff column 3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff 4 - apply patch, restart_all 5 - capture and revert your hold again 6 - confirm logs include diff showing change to found and priority Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 25.05! Well done everyone, thank you!