Bug 38531 - Include action_logs.diff when reverting hold
Summary: Include action_logs.diff when reverting hold
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-25 20:30 UTC by Andrew Fuerste-Henry
Modified: 2024-11-25 22:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38531: add diff when reverting hold (1.44 KB, patch)
2024-11-25 20:33 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38531: add diff when reverting hold (1.50 KB, patch)
2024-11-25 22:57 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-11-25 20:30:48 UTC
Bug 25159 added a diff column to action logs and made it populate for changes to holds. We missed adding that diff when reverting the hold waiting status.
Comment 1 Andrew Fuerste-Henry 2024-11-25 20:33:59 UTC
Created attachment 174983 [details] [review]
Bug 38531: add diff when reverting hold

To test:
1 - place, capture, and revert a hold
2 - view action logs for your hold via SQL so you can see the diff column
3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff
4 - apply patch, restart_all
5 - capture and revert your hold again
6 - confirm logs include diff showing change to found and priority
Comment 2 Biblibre Sandboxes 2024-11-25 22:57:38 UTC
Created attachment 174984 [details] [review]
Bug 38531: add diff when reverting hold

To test:
1 - place, capture, and revert a hold
2 - view action logs for your hold via SQL so you can see the diff column
3 - confirm reversion of waiting hold generates a MODIFY line in logs with no diff
4 - apply patch, restart_all
5 - capture and revert your hold again
6 - confirm logs include diff showing change to found and priority

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>