| Summary: | dataTables assets included but no longer exist | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to oldstable --- | QA Contact: | Matt Blenkinsop <matt.blenkinsop> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, matt.blenkinsop, wainuiwitikapark |
| Version: | Main | Keywords: | rel_24_11_candidate |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the cause of a file not found message in log files when displaying the checkouts table for a patron (for any patron with current checkouts > Check out > Checkouts tab > Show checkouts). It removes the reference to the rowGroup data tables plugin assets - these no longer exist, as the plugin is now part of DataTables. (This is related to the upgrade to DataTables 2.x in Koha 24.11.)
|
Version(s) released in: |
25.05.00,24.11.01
|
| Circulation function: | |||
| Bug Depends on: | 36640 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38543: Do not include rowGroup asset files
Bug 38543: Do not include rowGroup asset files Bug 38543: Do not include rowGroup asset files |
||
|
Description
Jonathan Druart
2024-11-27 08:54:19 UTC
Created attachment 175001 [details] [review] Bug 38543: Do not include rowGroup asset files rowGroup plugin is now part of the datatables.min.js bundle. We no longer need to include its css and js files, and they no longer exist anyway! [2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107 [2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84. Test plan: Confirm that the checkouts are grouped "today" and "previous" on the checkout page. Created attachment 175012 [details] [review] Bug 38543: Do not include rowGroup asset files rowGroup plugin is now part of the datatables.min.js bundle. We no longer need to include its css and js files, and they no longer exist anyway! [2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107 [2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84. Test plan: Confirm that the checkouts are grouped "today" and "previous" on the checkout page. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Check out an item to a patron. 2. In one terminal window, access the ktd shell and tail the logs: tail -f /var/log/koha/kohadev/* 3. Refresh the patron's page and in the "Check out" section > Checkouts, click "Show checkouts". 4. Note the warning message in the logs: ==> /var/log/koha/kohadev/plack-intranet-error.log <== [2024/11/27 18:42:28] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107. [2024/11/27 18:42:28] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84. 5. In another terminal window, apply the patch, and restart everything. 6. Repeat step 3 and note that is no longer a file not found warning. Created attachment 175048 [details] [review] Bug 38543: Do not include rowGroup asset files rowGroup plugin is now part of the datatables.min.js bundle. We no longer need to include its css and js files, and they no longer exist anyway! [2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107 [2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84. Test plan: Confirm that the checkouts are grouped "today" and "previous" on the checkout page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.01 Backported to 24.05.x for 24.05.06 (In reply to Wainui Witika-Park from comment #7) > Backported to 24.05.x for 24.05.06 Depends on Bug 36640 not in 24.05.x, you may need to revert (In reply to Fridolin Somers from comment #8) > (In reply to Wainui Witika-Park from comment #7) > > Backported to 24.05.x for 24.05.06 > > Depends on Bug 36640 not in 24.05.x, you may need to revert Thanks, reverted from 24.05 |