Bug 38543 - dataTables assets included but no longer exist
Summary: dataTables assets included but no longer exist
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Matt Blenkinsop
URL:
Keywords: rel_24_11_candidate
Depends on: 36640
Blocks:
  Show dependency tree / graph
 
Reported: 2024-11-27 08:54 UTC by Jonathan Druart
Modified: 2024-12-03 16:36 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the cause of a file not found message in log files when displaying the checkouts table for a patron (for any patron with current checkouts > Check out > Checkouts tab > Show checkouts). It removes the reference to the rowGroup data tables plugin assets - these no longer exist, as the plugin is now part of DataTables. (This is related to the upgrade to DataTables 2.x in Koha 24.11.)
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 38543: Do not include rowGroup asset files (3.68 KB, patch)
2024-11-27 08:59 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 38543: Do not include rowGroup asset files (3.73 KB, patch)
2024-11-27 19:02 UTC, David Nind 		Details | Diff | Splinter Review
Bug 38543: Do not include rowGroup asset files (3.81 KB, patch)
2024-12-02 10:45 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-11-27 08:54:19 UTC 
rowGroup plugin is now part of the datatables.min.js bundle. We no longer need to include its css and js files, and they no longer exist anyway!

[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107.
[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84.
Comment 1 Jonathan Druart 2024-11-27 08:59:03 UTC 
Created attachment 175001 [details] [review]
Bug 38543: Do not include rowGroup asset files

rowGroup plugin is now part of the datatables.min.js bundle. We no
longer need to include its css and js files, and they no longer exist
anyway!

[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107
[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84.

Test plan:
Confirm that the checkouts are grouped "today" and "previous" on the
checkout page.
Comment 2 David Nind 2024-11-27 19:02:24 UTC 
Created attachment 175012 [details] [review]
Bug 38543: Do not include rowGroup asset files

rowGroup plugin is now part of the datatables.min.js bundle. We no
longer need to include its css and js files, and they no longer exist
anyway!

[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107
[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84.

Test plan:
Confirm that the checkouts are grouped "today" and "previous" on the
checkout page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-11-27 19:38:16 UTC 
Testing notes (using KTD):

1. Check out an item to a patron.
2. In one terminal window, access the ktd shell and tail the logs: tail -f /var/log/koha/kohadev/*
3. Refresh the patron's page and in the "Check out" section > Checkouts, click "Show checkouts".
4. Note the warning message in the logs:

==> /var/log/koha/kohadev/plack-intranet-error.log <==
[2024/11/27 18:42:28] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107.
[2024/11/27 18:42:28] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84.

5. In another terminal window, apply the patch, and restart everything.
6. Repeat step 3 and note that is no longer a file not found warning.
Comment 4 Matt Blenkinsop 2024-12-02 10:45:43 UTC 
Created attachment 175048 [details] [review]
Bug 38543: Do not include rowGroup asset files

rowGroup plugin is now part of the datatables.min.js bundle. We no
longer need to include its css and js files, and they no longer exist
anyway!

[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/stylesheets/rowGroup.dataTables.min.css at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 107
[2024/11/27 08:52:37] [WARN] File not found : lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js at /kohadevbox/koha/Koha/Template/Plugin/Asset.pm line 84.

Test plan:
Confirm that the checkouts are grouped "today" and "previous" on the
checkout page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-12-03 16:36:33 UTC 
Pushed for 25.05!

Well done everyone, thank you!