Summary: | Table settings behavior broken on some tables in the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Pushed to stable --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, lucas, paul.derscheid |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes three OPAC tables (holds history, checkout history, and search history) that were not working correctly. This was caused by a JavaScript error (Uncaught TypeError: table_settings.columns is undefined). (This is related to the DataTables upgrade in Koha 24.11.)
|
|
Version(s) released in: |
25.05.00,24.11.01
|
Circulation function: | |
Bug Depends on: | 38436 | ||
Bug Blocks: | |||
Attachments: |
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC Bug 38595: Fix broken table settings behaviour on some tables at the OPAC |
Description
Jonathan Druart
2024-12-02 10:48:19 UTC
Created attachment 175049 [details] [review] Bug 38595: Fix broken table settings behaviour on some tables at the OPAC Problem highlighted by bug 38436. There is a JS error on some views with tables at the OPAC. Uncaught TypeError: table_settings.columns is undefined Test plan: Go to the 3 views modified by this patch and confirm that the JS error in the console is gone when this patch is applied. Created attachment 175051 [details] [review] Bug 38595: Fix broken table settings behaviour on some tables at the OPAC Problem highlighted by bug 38436. There is a JS error on some views with tables at the OPAC. Uncaught TypeError: table_settings.columns is undefined Test plan: Go to the 3 views modified by this patch and confirm that the JS error in the console is gone when this patch is applied. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 175062 [details] [review] Bug 38595: Fix broken table settings behaviour on some tables at the OPAC Problem highlighted by bug 38436. There is a JS error on some views with tables at the OPAC. Uncaught TypeError: table_settings.columns is undefined Test plan: Go to the 3 views modified by this patch and confirm that the JS error in the console is gone when this patch is applied. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.01 |