Bug 38595 - Table settings behavior broken on some tables in the OPAC
Summary: Table settings behavior broken on some tables in the OPAC
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 38436
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-02 10:48 UTC by Jonathan Druart
Modified: 2025-02-04 20:37 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes three OPAC tables (holds history, checkout history, and search history) that were not working correctly. This was caused by a JavaScript error (Uncaught TypeError: table_settings.columns is undefined). (This is related to the DataTables upgrade in Koha 24.11.)
Version(s) released in:
25.05.00,24.11.01
Circulation function:


Attachments
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC (3.63 KB, patch)
2024-12-02 10:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC (3.67 KB, patch)
2024-12-02 12:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC (3.73 KB, patch)
2024-12-02 18:29 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-12-02 10:48:19 UTC
Problem highlighted by bug 38436. There is a JS error on some views with tables at the OPAC.

  Uncaught TypeError: table_settings.columns is undefined
Comment 1 Jonathan Druart 2024-12-02 10:50:22 UTC
Created attachment 175049 [details] [review]
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC

Problem highlighted by bug 38436. There is a JS error on some views with tables at the OPAC.

  Uncaught TypeError: table_settings.columns is undefined

Test plan:
Go to the 3 views modified by this patch and confirm that the JS error in
the console is gone when this patch is applied.
Comment 2 Owen Leonard 2024-12-02 12:41:22 UTC
Created attachment 175051 [details] [review]
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC

Problem highlighted by bug 38436. There is a JS error on some views
with tables at the OPAC.

  Uncaught TypeError: table_settings.columns is undefined

Test plan:
Go to the 3 views modified by this patch and confirm that the JS error
in the console is gone when this patch is applied.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass (lukeg) 2024-12-02 18:29:04 UTC
Created attachment 175062 [details] [review]
Bug 38595: Fix broken table settings behaviour on some tables at the OPAC

Problem highlighted by bug 38436. There is a JS error on some views
with tables at the OPAC.

  Uncaught TypeError: table_settings.columns is undefined

Test plan:
Go to the 3 views modified by this patch and confirm that the JS error
in the console is gone when this patch is applied.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-12-03 16:36:38 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2024-12-12 13:31:32 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01